[HOLD for payment 2023-09-07] [$1000] Android - Back button is overlapping with notification bar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app and sign in with an account that doesn't have lounge access
2. Using deeplink, open https://staging.new.expensify.com/settings/profile/lounge-access

Expected Result:

Back button must be visible to user

Actual Result:

Back button is overlapping with notification bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.20230817.231714.New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: @rushatgabhane

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691486921365289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01995c8bbede070619
• Upwork Job ID: 1692650230241669120
• Last Price Increase: 2023-08-25
• Automatic offers:
• hoangzinh | Contributor | 26334470

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ShogunFire]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The back button is overlapping with the notification bar in lounge acess page when we are not allowed

What is the root cause of that problem?

When the user is not allowed, we return the component FullPageNotFoundView here:

App/src/pages/settings/Profile/LoungeAccessPage.js

Lines 41 to 43 in ca8372f

	if (!user.hasLoungeAccess) {
	return <FullPageNotFoundView shouldShow />;
	}

In order for this component to display correctly it needs to be surrounded by a ScreenWrapper

What changes do you think we should make in order to solve the problem?

We need to add a ScreenWrapper around the FullPageNotFoundView in LoungeAccessPage

What alternative solutions did you explore? (Optional)

We can also consider putting a ScreenWrapper for the component when the user is allowed because the same thing might happen

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Back button is overlapping with notification bar

What is the root cause of that problem?

When user doesn't have access to lounge page, it renders FullPageNotFoundView

App/src/pages/settings/Profile/LoungeAccessPage.js

Lines 41 to 43 in 08b75f3

	if (!user.hasLoungeAccess) {
	return <FullPageNotFoundView shouldShow />;
	}

FullPageNotFoundView is just a component to render not found view, it doesn't have any padding top/bottom with the screen like ScreenWrapper.

What changes do you think we should make in order to solve the problem?

In other screen places, we usually render NotFoundPage instead of FullPageNotFoundView if we would like to render not found screen. I.e ContactMethod, withReportOrNotFound HOC...
So in this Lounge access screen, we need to do same thing, we should render NotFoundPage instead of FullPageNotFoundView in those LOC

[joekaufmanexpensify]

Yeah, the button is definitely in the wrong place here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01995c8bbede070619

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)