[HOLD for payment 2023-09-29] [$1000] Web - Profile - Profile error is not dismissed even after opening further menus and coming back

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open profile
4. Click on profile pic and upload unsupported image eg: webp format image
5. Observe that app displays error below profile picture
6. Open any submenu like Display name, Contact method and revisit back to profile
7. Observe that error is still not dismissed

Expected Result:

App should dismiss error on profile page as soon as we navigate to another page

Actual Result:

App does not dismiss error on profile page even when we navigate to another page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2575716424650642242error_not_dismissed_profile_page.MP4

Recording.5886.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691319644122389

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ab616209feb88d9
• Upwork Job ID: 1692451442740764672
• Last Price Increase: 2023-08-25
• Automatic offers:
• jjcoffee | Reviewer | 26401335
• dukenv0307 | Contributor | 26401336
• Dhanashree-Sawant | Reporter | 26401337

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile error is not dismissed even after opening further menus and coming back

What is the root cause of that problem?

We use Navigation.navigate to open other menus so ProfilePage is already in stack navigator. And then when we goBack to this page, the old state is displayed and we don't clear the error in AvatarWithImagePicker if the page is focused again.

App/src/pages/settings/Profile/ProfilePage.js

Line 131 in a03a21d

onPress={() => Navigation.navigate(detail.pageRoute)}

What changes do you think we should make in order to solve the problem?

In AvatarWithImagePicker, we should use withNavigationFocus HOC to listen when the page is focused and then in componentDidUpdate we will clear the error if it is focused.

if (!prevProps.isFocused && this.props.isFocused) {
    this.setError(null, {})
}

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-08-14.at.11.06.28.mov

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app should dismiss the error on the profile page as soon as we navigate to another page

What is the root cause of that problem?

We are saving the error at state:

App/src/components/AvatarWithImagePicker.js

Lines 111 to 113 in ed2c287

	this.state = {
	isMenuVisible: false,
	validationError: null,

We are saving an error in the state, That's why when we go to the next page and then back to the previous page will not unmount that's why the state is not clear

What changes do you think we should make in order to solve the problem?

We should add the logic to clear error when the page is visible again in componentDidUpdate using withNavigationFocus.

        if (!prevProps.isFocused && this.props.isFocused) {
            this.setError(null,{});
        }

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ab616209feb88d9

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[lucentdevteam]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[$1000] Web - Profile - Profile error is not dismissed even after opening further menus and coming back #25405 - Expensify

What is the root cause of that problem?

Because validationError variable is part of state and is not updated automatically during navigating to other pages

What changes do you think we should make in order to solve the problem?

I feel we should add following changes in code

• State should be updated with page change

What alternative solutions did you explore? (Optional)

• We feel we can auto hide errors, by change error status to false after 3 seconds.