[HOLD for payment 2023-09-06] [$1000] Workspace - Highlight on text is displayed when email is pressed in Bills screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #24244

Action Performed:

1. Open app in iOS
2. Go to Settings > Workspaces > Select a Workspace > Bills
3. Tap on the email shown in the Manage your bills section

Expected Result:

No highlight on text when email is pressed

Actual Result:

Highlight is displayed when email is pressed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.54.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6165815_24244_iOS.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7076c95fa743b6d
• Upwork Job ID: 1692325576877830144
• Last Price Increase: 2023-08-18
• Automatic offers:
• mollfpr | Reviewer | 26302490

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Highlight on text is displayed when email is pressed in Bills screen

What is the root cause of that problem?

The root cause of the issue is that the container for PressableWithDelayToggle is Text by default. In react native, for iOS, by default, Text has a background colour in pressed state. We're not suppressing the default highlight here.

What changes do you think we should make in order to solve the problem?

We need to add the following here:

            {...props.inline && {suppressHighlighting: true}}

We need to add the above for iOS only, although adding it for all platforms wouldn't really cause any error. We're already doing this here. If that is not an option, then, I think a cleaner way to add this on iOS only would be to create a platform specific Text component that has highlighting disabled by default and name it something like TextWithoutHighlight and use that instead.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

@joekaufmanexpensify I think the test steps should be updated because this is only reproducible once you are logged in with a non-public domain email account ie user.isFromPublicDomain is false.

[joekaufmanexpensify]

I'm unable to reproduce this at all on iOS (in either an expensifail account, or in a public domain account).

[joekaufmanexpensify]

@allroundexperts could you please share what you're seeing in a public domain account?

[allroundexperts]

Here's what it looks like with a public domain account:

https://github.com/Expensify/App/assets/30054992/5cb636e6-a6fb-45cf-aebe-55f89f84737a

[joekaufmanexpensify]

I don't think that is a bug. There is nothing to select there purposefully as public domain emails do not have a bill intake email address to send in bills (as they don't have a private domain).

[allroundexperts]

Sorry, this happens when you're NOT on a public domain email.

[allroundexperts]

Here is how it looks for non-public emails:

[joekaufmanexpensify]

Got it, thanks for clarifying that!

[joekaufmanexpensify]

Yeah, I cannot reproduce this at all on iOS v1.3.54-11. This is what I see: