[HOLD for payment 2023-09-20] [$1000] iOS - Chat - After going back from the sub-thread and editing the message, the Chat Composer is hidden behind the keyboard

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to Account A >> Open any chat report.
2. Send a message to the chat (if A hasn't sent any message before)
3. Long press on the message created at step 3 and select the "Reply in thread" option (KEY step).
4. Go back to the main chat.
5. Long press on the message again and select the "Edit comment" option.
6. Chat composer is hidden behind the keyboard.
   (Note: The only way to make it work again is to leave the chat and reopen it)

Expected Result:

The chat composer shouldn't be hidden behind the keyboard, so the user can see what they are typing.

Actual Result:

The chat composer is hidden behind the keyboard, making it impossible for the user to see what they typed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.53-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

-5396640507154347086hidden-composer.1.MP4

2023.08.14.23.33.Img.0413.mp4

Expensify/Expensify Issue URL:

Issue reported by: @tranvantoan-qn

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691173341567539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c49f282cc4a51c0a
• Upwork Job ID: 1696693806832926720
• Last Price Increase: 2023-08-30
• Automatic offers:
• cubuspl42 | Reviewer | 26408299
• ShogunFire | Contributor | 26408300
• Tranvantoan-qn | Reporter | 26408301

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ShogunFire]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The composer is hidden behind the keyboard when we go to a child report

What is the root cause of that problem?

In ReportScreen we set if the KeyboardAvoidingView should be enable here:
https://github.com/adamgrzybowski/App/blob/ff423aa61fde128e981ee071b01011238927516c/src/pages/home/ReportScreen.js#L294

The keyboard avoiding view is enabled only if we are in the top most report.

When we go to a child report the parent is not the top most report anymore so the keyboard avoidingview is disabled. When we go back the parent should be notified that he is the top most report but this is not the case, he doesn't rerender.

What changes do you think we should make in order to solve the problem?

In order for the parent report to rerender and update the behaviour of keyboard avoiding view, ReportScreen should subscribe to the onyx event withCurrentReportID that is firing when the top most report changes

Result:

2023-08-14.21-12-37.mp4

What alternative solutions did you explore? (Optional)

[dummy-1111]

This is a dupe of #23423
I reported several times but @isabelastisser didn't reply

[ShogunFire]

Maybe we can handle it here then ?

[tranvantoan-qn]

I don't know what the best option is, as the previous issue is CLOSED; therefore, I couldn't determine if it had been reported earlier. And since it is CLOSED without a fix, I don't think it will ever get another chance to be checked/fixed unless someone got the same issue and reports it again.

So let @mallenexpensify check it first, and he will provide the option that best suits us.

[melvin-bot]

@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mallenexpensify]

@tranvantoan-qn and @s-alves10 are there more instances of the keyboard being hidden? If so, I'd like to work on them all in one issue.

I was able to reproduce this