Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the staging web link
2. Go to Settings > Workspaces
3. Select a workspace to open WS settings
4. Go back to workspace list by tapping on the back button

Expected Result:

No visual issues / screen should slide smoothly

Actual Result:

Visual flickering on the button "New workspace" when going back to workspace list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159271_RPReplay_Final1691599332__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cbc57cc70a4d58dc
• Upwork Job ID: 1689518567778115584
• Last Price Increase: 2023-08-24

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

I'm able to reproduce this and I think this is a design polish (but necessary)

RPReplay_Final1691647496.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cbc57cc70a4d58dc

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[swakeert]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On ios/ Safari, when navigating back to the Workspace list from a particular workspaces' setting, there is a visual flickering and occasional movement of "New Workspace" text.

What is the root cause of that problem?

On moving between the Workspace list and Workspace Setting page, there is a change in the safe area background. When the Workspace setting page is unmounted, it is causing a slightly delayed re-render of the footer and safe area which is causing the 'flickering' effect.

What changes do you think we should make in order to solve the problem?

We need to inspect the state and find the root cause of the re-render. And ensure it does not perform the re-render when coming back from the workspace setting page.

What alternative solutions did you explore? (Optional)

I checked the transition effects on the footer and headerPageLayout and its child components to see what could have caused the re-render, but did not find anything.

[Thanos30]

I personally can't replicate it in my local environment, so that makes it hard to test. I found this which might be useful:

react-navigation/react-navigation#9530