[HOLD for payment 2023-09-06] [$1000] After deleting the last thread message, the 'completed task' message briefly appears in English instead of Spanish

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Preferences > Language
2. Select the Spanish language
3. Go back and open a chat
4. Go to the "Assign task" section
5. Enter a title and create the task
6. Click on the ‘Mark as done’ button
7. Send a thread message after that
8. Now delete the thread message
9. Observe that the LHN shows the 'completed task' message in English for a while

Expected Result:

After deleting the last thread message, the 'completed task' message should be displayed in Spanish consistently

Actual Result:

When deleting the thread message, the 'completed task' message briefly appears in English before switching to Spanish

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.50.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-01-at-100505-pm_4ogcW5W3.mp4

Recording.1121.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690910046289219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ee84b5eaf49507dc
• Upwork Job ID: 1690148058207748096
• Last Price Increase: 2023-08-18
• Automatic offers:
• DanutGavrus | Contributor | 26241879

[DanutGavrus]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting the last thread message, the completed task message briefly appears in English instead of Spanish.

What is the root cause of that problem?

In OptionRowLHN, we show the optionItem.alternateText. The optionItem comes from SidebarUtils.getOptionData method which sets the alternateText.

App/src/libs/SidebarUtils.js

Lines 307 to 318 in e555022

	if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport) && !result.isArchivedRoom) {
	const lastAction = visibleReportActionItems[report.reportID];
	if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.RENAMED) {
	const newName = lodashGet(lastAction, 'originalMessage.newName', '');
	result.alternateText = Localize.translate(preferredLocale, 'newRoomPage.roomRenamedTo', {newName});
	} else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKREOPENED) {
	result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.reopened')}: ${report.reportName}`;
	} else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED) {
	result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.completed')}: ${report.reportName}`;
	} else {
	result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');
	}

1. It uses the translate method, but the problem is that when we delete the last action, we do not filter it out. So, first time getOptionData runs with the action which has pending delete, it does not trigger any of the ifs, and gets to the result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet') which sets the text the lastMessageText which is Completed task: title.
2. After that action gets deleted, the second run runs with the appropriate action and triggers the if in which the translate method is used, and actually returns the Spanish text now.

What changes do you think we should make in order to solve the problem?

We should filter out the actions from here which have pending delete in them such that the getOptionData method will run with the appropriate action from the start, and will actually trigger the if in which the translate method is used:

const reportActionsForDisplay = _.filter(
    actionsArray,
    (reportAction, actionKey) => ReportActionsUtils.shouldReportActionBeVisible(reportAction, actionKey) && reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED && reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE // <-- added last condition
);

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

This one is on my testing list.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ee84b5eaf49507dc

[melvin-bot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.