[HOLD for payment 2023-09-04] [$1000] Tap with two fingers on Mark as done button opens assignee screen

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click FAB -> Create task for someone
2. Go to task details -> Tap Mark as done button with two Fingers
   Or
   Tap and hold button click and Tap with other finger

Expected Result:

It should not redirect to other screen & Button UI should stay single focus

Actual Result:

1. It redirects to Assignee screen
2. Button darks out twice

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.13.MP4

2023.08.04.10.48.Img.0224.mp4

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690837745266379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01828e7b9a9852bda3
• Upwork Job ID: 1688641968597434368
• Last Price Increase: 2023-08-07

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tap the Mark as done button with 2 fingers will open the assignee selector page.

What is the root cause of that problem?

I don't have a physical iOS device, but on Android, when we tap it with 2 fingers, we can see it dims really dark. And on the Web (actually on every platform), we can click at the very edge of the button and it will open the assignee selector page.

The reason is that the mark as done button is wrapped with another PressableWithFeedback that will navigate the user to the assignee selector page.

App/src/components/TaskHeaderActionButton.js

Lines 38 to 60 in 8e608db

	<PressableWithFeedback
	onPress={() => Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID))}
	disabled={!ReportUtils.isOpenTaskReport(props.report)}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	accessibilityLabel={props.translate('task.assignee')}
	hoverDimmingValue={1}
	pressDimmingValue={0.2}
	>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentEnd]}>
	<Button
	success
	isDisabled={ReportUtils.isCanceledTaskReport(props.report) || !Task.canModifyTask(props.report, props.session.accountID)}
	medium
	text={props.translate(ReportUtils.isCompletedTaskReport(props.report) ? 'task.markAsIncomplete' : 'task.markAsDone')}
	onPress={() =>
	ReportUtils.isCompletedTaskReport(props.report)
	? Task.reopenTask(props.report.reportID, props.report.reportName)
	: Task.completeTask(props.report.reportID, props.report.reportName)
	}
	style={[styles.flex1]}
	/>
	</View>
	</PressableWithFeedback>

What changes do you think we should make in order to solve the problem?

Remove the unused PressableWithFeedback

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01828e7b9a9852bda3

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[Thanos30]

@jasperhuangg Is there a reason behind the wrapping of the button with PressableWithFeedbackin in the TaskHeaderActionButton file?

I see the PR was created by you about a month ago, I just wanted to clarify the purpose of it in order to come up with a solution.

Thanks 🙏

[mollfpr]

It looks like a regression from the task detail redesign PR #20841.

IIRC, before the redesign, we can click the task header to assign a user to the task and the component used to wrap the display name and avatar. So it might be Jasper forget to remove the PressableWithFeedback for that.

As mentioned in @bernhardoj's proposal, I think we can safely remove it. Let's go with @bernhardoj proposal then.

🎀 👀 🎀 C+ reviewed!