[HOLD for payment 2023-09-04] [$1000] Fix require cycle from `subscribeToReportCommentPushNotifications`

[arosiclair]

Action Performed:

Run the app on Android

Expected Result:

No warnings about a require cycle

Actual Result:

A warning for a require cycle occurs.

WARN  Require cycle: src/libs/actions/Session/index.js -> src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.js -> src/libs/Notification/PushNotification/backgroundRefresh/index.android.js -> src/libs/actions/App.js -> src/libs/actions/Session/index.js

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e26d73a28da0cafc
• Upwork Job ID: 1687585347865071616
• Last Price Increase: 2023-08-17
• Automatic offers:
• dukenv0307 | Contributor | 26197726

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e26d73a28da0cafc

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[arosiclair]

@muttmuure no need to try to reproduce this atm. This is a follow up for a console warning from this PR. I'll submit a PR to fix it and get it tested.

[arosiclair]

Holding until that PR is merged