[HOLD for payment 2023-08-28] [$1000] Triple clicking text and copying to clipboard results in text copied containing button text

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From user A, go to the chat with user B
2. From user B, send a message
3. From user A, Flag the message as violating
4. Click triple to the hidden message
5. Click the right pointer to open the context menu > Choose Copy to clipboard
6. Past this into the composer and notice the message copied

Expected Result:

The message copied shouldn't contain reveal button text

Actual Result:

The message copied contains reveal button text

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.50-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-01.at.17.19.37.mov

Recording.1445.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690886867471159

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012ab20f2847f765d5
• Upwork Job ID: 1688571815431098368
• Last Price Increase: 2023-08-07
• Automatic offers:
• bernhardoj | Contributor | 26116127
• dukenv0307 | Reporter | 26116129

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The issue is that when triple-clicking a hidden message and copying it to the clipboard, the copied text includes parts of the message that are not intended to be copied.

What is the root cause of that problem?

The issue occurs because of how the text selection is currently handled in the code. It's set to copy the selected text over the message text.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 182 to 190 in d4cd138

	onPress: (closePopover, {reportAction, selection}) => {
	const isReportPreviewAction = ReportActionUtils.isReportPreviewAction(reportAction);
	const message = _.last(lodashGet(reportAction, 'message', [{}]));
	const messageHtml = lodashGet(message, 'html', '');
	const isAttachment = _.has(reportAction, 'isAttachment') ? reportAction.isAttachment : ReportUtils.isReportMessageAttachment(message);
	if (!isAttachment) {
	const content = selection || messageHtml;
	if (isReportPreviewAction) {

What changes do you think we should make in order to solve the problem?

To fix this, we need to modify how the selection is handled. Specifically, we should ensure that only the user-generated message text can be selected, not any additional UI text or elements. Based on preference, candition can be modified like
const content = messageHtml;

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Triple-click the hidden message explanation will also copy the Reveal Message button text even though it's not selectable.

What is the root cause of that problem?

This issue is very similar to #18343 and #17838. When we triple-click, it will select the text and the text near it, in this case, the reveal message button. The reveal message button text itself is not selectable, but it's the browser bug that makes the non-selectable text gets copied too.

What changes do you think we should make in order to solve the problem?

We can apply the same solution from both issues above, that is to add
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
to the reveal button text, so it will be excluded when we copy the text.

[pbkompasz]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Triple click to text and copy to clipborad the text copied contains button text

What is the root cause of that problem?

1. The <Text /> element is missing the selectable prop.
2. The SelectionScraper returns a new string from the DOM. In this case we could remove the unwanted elements i.e. 'Hide messages' < Text/>

What changes do you think we should make in order to solve the problem?

Add selectable prop to <Text />

// Text.js
const propTypes = {
    // ...

    /** Should we make this selectable */
    selectable: PropTypes.boolean,
};

const defaultProps = {
    // ...
    selectable: true,
};

// ReportActionItem.js
<Text
  style={styles.buttonSmallText}
  selectable={false}
>
  {isHidden ? props.translate('moderation.revealMessage') : props.translate('moderation.hideMessage')}
</Text>

The getCurrentSelection method in SelectionScraper could receive an option to ignore the selectable===false elements.
In the replaceNodes we can remove these nodes

App/src/libs/SelectionScraper/index.js

Line 103 in 28f4fc2

const replaceNodes = (dom, isChildOfEditorElement) => {

What alternative solutions did you explore? (Optional)

When copying a message without the selection the button's text doesn't get copied.
Similarly when selecting the whole message we should get the same result.
Given this we could treat this as an edge case in

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 182 to 185 in 7b13f11

	onPress: (closePopover, {reportAction, selection}) => {
	const isReportPreviewAction = ReportActionUtils.isReportPreviewAction(reportAction);
	const message = _.last(lodashGet(reportAction, 'message', [{}]));
	const messageHtml = lodashGet(message, 'html', '');

// Check if selection contains the whole message (different implementation)
if (selection >= message) {
  selection = messageHtml;
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012ab20f2847f765d5

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.