[HOLD for payment 2023-09-06] [$1000] Web - On reload on attachment preview and close, app displays random chat for few seconds

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any image attachment
4. Click and open attachment in preview
5. Copy the attachment preview url
6. Go to other chat
7. Paste the saved url in the current search bar
8. Reload
9. Close the preview and observe that app displays random chat for few seconds before again displaying the right chat

Expected Result:

App should display same chat in which attachment is located when we close the preview - navigation should occur before closing the modal

Actual Result:

App displays random chat when we click on attachment, reload on preview and close the preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47.3
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

app.displays.random.chat.on.closing.preview.after.reload.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690103101672499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ceaa38feb4bfce8
• Upwork Job ID: 1687635491784937472
• Last Price Increase: 2023-08-05
• Automatic offers:
• tienifr | Contributor | 26201629
• dhanashree-sawant | Reporter | 26201630

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - On reload on attachment preview and close, app displays random chat for few seconds

What is the root cause of that problem?

The attachment view is main route, meanwhile the report screen is center pane so it's not related to each other.

App/src/libs/Navigation/linkingConfig.js

Lines 16 to 27 in cb8aac1

	[SCREENS.REPORT_ATTACHMENTS]: ROUTES.REPORT_ATTACHMENTS,
	// Sidebar
	[SCREENS.HOME]: {
	path: ROUTES.HOME,
	},
	[NAVIGATORS.CENTRAL_PANE_NAVIGATOR]: {
	screens: {
	[SCREENS.REPORT]: ROUTES.REPORT_WITH_ID,
	},
	},

The url of attachment view is /r/7572730112622440/attachment, it is not center pane so in ReportScreenWrapper we can't get the reportID, that why we get the last access report id to render in center pane

App/src/libs/Navigation/AppNavigator/ReportScreenWrapper.js

Lines 80 to 81 in cb8aac1

	// If there is no reportID in route, try to find last accessed and use it for setParams
	const reportID = getLastAccessedReportID(

the last access report id is different from the report id in url, so when we dismiss the attachment modal, we back to the current report then back to the report that contains attachment preview

App/src/pages/home/report/ReportAttachments.js

Line 33 in cb8aac1

onModalHide={() => Navigation.dismissModal(reportID)}

What changes do you think we should make in order to solve the problem?

1. Prior navigate to the parent report
   In

   App/src/libs/Navigation/AppNavigator/ReportScreenWrapper.js

   Lines 63 to 67 in cb8aac1

   	const getLastAccessedReportID = (reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom) => {
   	const lastReport = ReportUtils.findLastAccessedReport(reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom);
   	return lodashGet(lastReport, 'reportID');
   	};

We should additionally check the current route has the reportID not not by using Navigation.getActiveRoute()

Here's the code sample

    const currentRoute = Navigation.getActiveRoute();
    const regex = /\/r\/(\d*)\/attachment/;
    const reportID = regex.exec(currentRoute)[1] // should add null check
    if(reportID) return  reportID;

2. Avoid navigating to the parent report after closing modal

Remove reportID in

App/src/pages/home/report/ReportAttachments.js

Line 33 in cb8aac1

onModalHide={() => Navigation.dismissModal(reportID)}

Result

Screen.Recording.2023-08-01.at.11.37.05.mov

[tienifr]

@dhanashree-sawant @sakluger I think we should change the steps for more correct

1. Open the app
2. Open any report
3. Send any image attachment
4. Click and open attachment in preview
5. Copy the attachment preview url
6. Go to other chat
7. Paste the saved url in the current search bar
8. Reload
9. Close the preview and observe that app displays random chat for few seconds before again displaying the right chat

[dhanashree-sawant]

Okay yes, @tienifr steps seems better, if @sakluger is also able to reproduce with that step, we can change it.

[sakluger]

@tienifr thanks for providing those steps. Just to confirm, can you reproduce this issue consistently with those updated steps?

[tienifr]

Yes, I can @sakluger

[melvin-bot]

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!