[HOLD for payment 2023-08-24] [$1000] Task Report doesn't grey out when create task offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go offline
2. Create Task

Expected Result:

Task Report should grey out when create task offline

Actual Result:

Task Report doesn't grey out when create task offline

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-29.at.17.19.42.mov

Expensify/Expensify Issue URL:
Issue reported by: @ChengDzun
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690626730679279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01afec56cf0d694a04
• Upwork Job ID: 1685971979400462336
• Last Price Increase: 2023-07-31
• Automatic offers:
• ChengDzun | Contributor | 25928421
• ChengDzun | Reporter | 25928425

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from contributor

Please re-state the problem that we are trying to solve in this issue.

When making any actions offline the result of this action will be greyed out. But when creating a new task, the task report isn't greyed out

What is the root cause of that problem?

In ReportActionItem Component

App/src/pages/home/report/ReportActionItem.js

Lines 459 to 465 in eb02006

	if (ReportUtils.isTaskReport(props.report)) {
	return (
	<TaskView
	report={props.report}
	shouldShowHorizontalRule={!props.isOnlyReportAction}
	/>
	);

We don't wrap TaskReport by OfflineWithFeedback Component, so the offline pattern isn't applied

What changes do you think we should make in order to solve the problem?

We should wrap TaskReport by OfflineWithFeedback Component as we did here

App/src/pages/home/report/ReportActionItem.js

Line 531 in eb02006

<OfflineWithFeedback

We also consider doing the same thing with MoneyReportView Component

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01afec56cf0d694a04

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

Thanks for the proposal @ChengDzun. Could you elaborate on what props will be passed to the OfflineWithFeedback here?

@mananjadhav Because I can't update proposal. So I write this comment to resolve your question.

I think we only need to pass pendingAction field like this

<OfflineWithFeedback pendingAction={props.report.pendingFields}>  // We can also use props.action. pendingAction for this props. Both ways give the same result 
          <TaskView
               report={props.report}
               shouldShowHorizontalRule={!props.isOnlyReportAction}
           />
</OfflineWithFeedback>

This is result
Web:

Mobile: