[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] [$1000] App does not cancel 'Connect online with plaid' request on opening get assistance

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces and open any workspace
4. Open bank account
5. Click on 'Connect online with plaid' and while loading, click on get assistance icon in header
6. Observe that even though user have selected to open new page, app still opens next step of 'Connect online with plaid'

Expected Result:

App should cancel 'Connect online with plaid' request if we open another page before it is loaded OR App should disable other buttons when loading for 'Connect online with plaid'

Actual Result:

App does not cancel 'Connect online with plaid' request and displays next step even though user have already opened another page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Does.not.cancel.plaid.connect.request.mp4

Recording.1404.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690625251424159

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0107644af3ed1e8537
• Upwork Job ID: 1686474836563587072
• Last Price Increase: 2023-08-22

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not cancel 'Connect online with plaid' request on opening get assistance.

What is the root cause of that problem?

Currently, we don't implement any logic to stop opening Plaid Link when navigating to other screens.

What changes do you think we should make in order to solve the problem?

We need to stop opening Plaid Link and bring it back to the beginning option. In AddPlaidBankAccount component:

• Use useIsFocused hook.
• Once PlaidLink open, its view will cover all screen. If isFocused is false, it means PlaidLink has not opened yet, we will reset the process.

const isFocused = useIsFocused();

useEffect(() => {
  if (!isFocused && !plaidBankAccounts.length) {
      onExitPlaid();
  }
  // For the case users click to backdrop modal.
  return () => {
      if (!plaidBankAccounts.length) {
          onExitPlaid();
      }
  };
}, [isFocused])

• plaidBankAccounts.length is the condition to render Plaid Link view

Result

Screen.Recording.2023-08-15.at.12.39.32.AM.mov

Screen.Recording.2023-08-15.at.12.40.48.AM.mov

Screen.Recording.2023-08-15.at.12.41.10.AM.mov

[CortneyOfstad]

Site slows, so going to try and recreate this later 👍

[CortneyOfstad]

@kavimuru I wasn't able to recreate this. Can we confirm this issue is still happening?

[dhanashree-sawant]

Hi @CortneyOfstad, I cross checked and was still able to recreate, can you let me know what you see on clicking get assistance icon after clicking on 'Connect online with Plaid'?

[CortneyOfstad]

I was able to get this to recreated, so getting eyes on it. Also I'm heading OoO until 8/14 so reassigning BZ to keep an eye on things while I'm out 👍