[HOLD for payment 2023-08-16] [$1000] Web - The state name in the company information does not update to "Incorporation State," causing both state names to appear the same

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces
2. Select a workspace and access "Connect Bank Account."
3. Proceed to Step 2 out of 5.

Expected Result:

The second state name in the company information should be changed to "Incorporation State."

Actual Result:

The state name in the company information does not update to "Incorporation State," causing both state names to appear the same

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-29.at.1.33.54.AM.mov

Recording.3998.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690576478988209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0180f3b211410f7a0c
• Upwork Job ID: 1686400237560549376
• Last Price Increase: 2023-08-10
• Automatic offers:
• dhairyasenjaliya | Contributor | 25889382

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The state name in the company information does not update to "Incorporation State," causing both state names to appear the same

What is the root cause of that problem?

• The root cause is we are not accepting custom title on StatePicker component that stick to the same label as state

What changes do you think we should make in order to solve the problem?

• The solution is we should define new props for adding custom label directly to <State> component

• After defining the customLabel props this should be added to <MenuItemWithTopDescription> as an description props and we should also pass this to <StateSelectorModal> that we are using on <State> component

• On SelectionListRadio we need to add. customLabel to textInputLabel on <StateSelectorModal>

• Above both will fix component and selector page as well

• We can also pass this same custom label to <HeaderWithBackButton> title props on <StateSelectorModal> so that page title can also have consistency

• We already have translate key for that we can just use that or define new key

• Fallback value for customLabel props should be translate('common.state’)

What alternative solutions did you explore? (Optional)

• N/A
  ———————

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0180f3b211410f7a0c

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[kevinksullivan]

@mananjadhav are you able to review the proposal above?