[Ready for payment - $1000] mWeb- Chat- In secondary device, in real time, emoji selected is not updated in frequently used

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre- con: In 2 device, open same account, same conversation, open emoji picker

1. Go to https://staging.new.expensify.com/
2. Tap on a conversation as mentioned in one condition
3. Tap on emoji picker
4. Select emoji which is not in frequently used
5. Tap emoji picker again to see selected emoji in frequently used
6. Notice the same conversation and emoji picker opened in secondary device

Expected Result:

In secondary device, in real time, emoji selected must be updated in frequently used list.

Actual Result:

In secondary device, in real time, emoji selected is not updated in frequently used list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6144776_redmi.mp4

Bug6144776_samsung2nd_device.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017543882e0e6eca1f
• Upwork Job ID: 1685003669049524224
• Last Price Increase: 2023-07-28

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the frequently used emojis to be updated in real-time on secondary devices.

What is the root cause of that problem?

When are not updating the already rendered frequently used emojis in device B when we update frequently used emojis in device A.

What changes do you think we should make in order to solve the problem?

We can listen to ONYXKEYS.FREQUENTLY_USED_EMOJIS and based on that update frequently used emojis.

What alternative solutions did you explore? (Optional)

N/A

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat- In secondary device, in real time, emoji selected is not updated in frequently used

What is the root cause of that problem?

From the log, I found that BE already sent pusher event to secondary device about frequentlyUsedEmojis

But unfortunately, in EmojiPickerMenu component, we just pick up frequentlyUsedEmojis in initializer function of component

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 60 to 72 in 7754c7a

	this.emojis =
	getOperatingSystem() === CONST.OS.WINDOWS
	? EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojis.slice(0, flagHeaderIndex))
	: EmojiUtils.mergeEmojisWithFrequentlyUsedEmojis(emojis);
	// Get the header emojis along with the code, index and icon.
	// index is the actual header index starting at the first emoji and counting each one
	this.headerEmojis = EmojiUtils.getHeaderEmojis(this.emojis);
	// This is the indices of each header's Row
	// The positions are static, and are calculated as index/numColumns (8 in our case)
	// This is because each row of 8 emojis counts as one index to the flatlist
	this.headerRowIndices = _.map(this.headerEmojis, (headerEmoji) => Math.floor(headerEmoji.index / CONST.EMOJI_NUM_PER_ROW));

When the frequentlyUsedEmojis is updated, we haven't had any logic to update states filteredEmojis and headerIndices yet.

What changes do you think we should make in order to solve the problem?

1. We need to include ONYXKEYS.FREQUENTLY_USED_EMOJIS into withOnyx HOC => It will inform component to updates when this data in Onyx is updated
2. In componentDidUpdate of EmojiPickerMenu component, we need to check if the props.frequentlyUsedEmojis is updated, we need to recompute the states filteredEmojis and headerIndices like the this in the initializer here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017543882e0e6eca1f

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[AdeemWaseem]

Contributor details
Your Expensify account email: adeemwaseemmalik92@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01d2b054d1769064c3

Issue:

The issue is that the app crashes when navigating to the /details page directly from the /expenses page.

Proposal:

The following changes will be made to fix the issue:

The /details page will be made to load asynchronously. This will prevent the app from crashing if the page takes a long time to load.
The /details page will be made to check for the existence of the expense before loading. This will prevent the app from crashing if the expense does not exist.
The /details page will be made to handle errors more gracefully. This will prevent the app from crashing if an error occurs while loading the page.
Steps to implement the proposal:

Create a fork of the Expensify/App GitHub repo.
Create a branch on the fork and make the changes outlined in the proposal.
Test the changes on all platforms.
Create a pull request to merge the changes into the main repository.
Expected results:

The app will no longer crash when navigating to the /details page directly from the /expenses page.