[HOLD for payment 2023-08-16] [$1000] Web - No margin between composer box and whisper message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select new room option
2. Enter room name, add admin as who can post and set visibility to public
3. Click on create room button
4. Go to room report screen and click on header
5. Go to Share code and copy code
6. Paste that url to other users browser to add that user in room
7. Change who can post from admin to All members
8. Check space between composer box and whisper message
   in other users

Expected Result:

Should be some space between composer box and whisper message

Actual Result:

No space between composer box and whisper message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-8
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-26.at.5.15.20.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690374276965949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01885f7f425c61dd68
• Upwork Job ID: 1684801738734956544
• Last Price Increase: 2023-07-28
• Automatic offers:
• situchan | Reviewer | 25936924
• Pujan92 | Contributor | 25936926
• gadhiyamanan | Reporter | 25936927

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No gap between composer and the whisper message after changing the room settings

What is the root cause of that problem?

For the writeCapability we are not rerendering the ReportActionsView which is the cause of the issue and won't update the shouldOmitBottomSpace in ReportActionsList with new report data.

App/src/pages/home/report/ReportActionsView.js

Line 350 in 3d22f59

function arePropsEqual(oldProps, newProps) {

App/src/pages/home/report/ReportActionsList.js

Lines 168 to 170 in 3d22f59

	const isArchivedRoom = ReportUtils.isArchivedRoom(props.report);
	const hideComposer = ReportUtils.shouldHideComposer(props.report, errors);
	const shouldOmitBottomSpace = hideComposer || isArchivedRoom;

What changes do you think we should make in order to solve the problem?

Add writeCapability field condition within arePropsEqual function to rerender the component on its changed value.

    if (lodashGet(newProps, 'report.writeCapability') !== lodashGet(oldProps, 'report.writeCapability')) {
        return false;
    }

We can also update the code to remove const isArchivedRoom = ReportUtils.isArchivedRoom(props.report); as shouldHideComposer function already checking the isArchivedRoom.

[kadiealexander]

Repro:

2023-07-28_17-42-35.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01885f7f425c61dd68

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.