[C+ Checklist Needs Completion] [$1000] Task is not being reflected on LHN if task is created after sending an attachment

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat from the LHN
2. Send an attachment
3. Create a task inside the chat by clicking the plus icon inside the composer > assign task
4. Input the required fields and confirm the task
5. Observe the LHN of the opened report

Expected Result:

"Created task ..." should show up and the created task should also be reflected on the LHN

Actual Result:

Only "[Attachment]" is being shown in the LHN of the opened report

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-25.13.43.57.mp4

Recording.1351.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690282010882909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0146558a1a58c98ea3
• Upwork Job ID: 1684536150741610496
• Last Price Increase: 2023-07-27
• Automatic offers:
• StevenKKC | Contributor | 25993947
• nathan-mulugeta | Reporter | 25993948

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task is not being reflected on LHN if task is created after sending an attachment.

What is the root cause of that problem?

When create task, Task.createTaskAndNavigate is called, and optimisticReport is set as below.

App/src/libs/actions/Task.js

Lines 76 to 81 in 0d98268

	const optimisticReport = {
	lastVisibleActionCreated: currentTime,
	lastMessageText: lastCommentText,
	lastActorAccountID: currentUserAccountID,
	lastReadTime: currentTime,
	};

If send an attachment, the report's lastMessageTranslationKey is set to CONST.TRANSLATION_KEYS.ATTACHMENT.

App/src/libs/ReportUtils.js

Line 1461 in 0d98268

translationKey: isAttachment ? CONST.TRANSLATION_KEYS.ATTACHMENT : '',

App/src/libs/actions/Report.js

Line 258 in 0d98268

lastMessageTranslationKey: lodashGet(lastAction, 'message[0].translationKey', ''),

If create a task after send an attachment, the report's lastMessageTranslationKey does not be cleared.
So the report's last message text is retrieved as [ATTACHMENT], and the report's alternateText is also retrieved as [ATTACHMENT].

App/src/libs/isReportMessageAttachment.js

Lines 10 to 13 in 1205a74

	export default function isReportMessageAttachment({text, html, translationKey}) {
	if (translationKey) {
	return translationKey === CONST.TRANSLATION_KEYS.ATTACHMENT;
	}

App/src/libs/OptionsListUtils.js

Lines 381 to 382 in 0d98268

	if (ReportUtils.isReportMessageAttachment({text: report.lastMessageText, html: report.lastMessageHtml, translationKey: report.lastMessageTranslationKey})) {
	lastMessageTextFromReport = `[${Localize.translateLocal(report.lastMessageTranslationKey || 'common.attachment')}]`;

App/src/libs/SidebarUtils.js

Lines 287 to 289 in 0d98268

	let lastMessageText =
	hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID && Number(lastActorDetails.accountID) !== currentUserAccountID ? `${lastActorDetails.displayName}: ` : '';
	lastMessageText += report ? lastMessageTextFromReport : '';

App/src/libs/SidebarUtils.js

Line 311 in 0d98268

result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

Therefore, app display [ATTACHMENT] on LHN.

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 199 to 206 in 1205a74

	{optionItem.alternateText ? (
	<Text
	style={alternateTextStyle}
	numberOfLines={1}
	accessibilityLabel={translate('accessibilityHints.lastChatMessagePreview')}
	>
	{optionItem.isLastMessageDeletedParentAction ? translate('parentReportAction.deletedMessage') : optionItem.alternateText}
	</Text>

What changes do you think we should make in order to solve the problem?

We should clear lastMessageTranslationKey when create a task.

    const optimisticReport = {
        lastVisibleActionCreated: currentTime,
        lastMessageText: lastCommentText,
        lastActorAccountID: currentUserAccountID,
        lastReadTime: currentTime,
+       lastMessageTranslationKey: '',
    };

What alternative solutions did you explore? (Optional)

None.

[greg-schroeder]

Reviewing

[greg-schroeder]

Kinda seems similar to #22937

[Nathan-Mulugeta]

Hey @greg-schroeder did you check this conversation?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0146558a1a58c98ea3

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.