[HOLD for payment 2023-08-30] [$1000] Web - Markdown pasted from selection-copy is different from clipboard-copy

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Paste this markdown (it has a heading, then a code snippet and a quote)

test heading

Code snippet

link

3. Now use the copy to clipboard option, and copy the sent message
4. Paste the message in the composer and send it again (notice that there are no difference in both messages)
5. Now select the sent message text by cursor and press cmd+c
6. Paste the text in the composer and send the message.
7. Notice that the markdown message has an extra line in the code snippet part.

Expected Result:

Message copied from selection should be the same that that copied from context menu

Actual Result:

Message copied from selection has an extra line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-26.at.2.34.29.PM.mp4

Recording.3922.mp4

Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690364432300409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c94943755b5fa6d
• Upwork Job ID: 1684694244929720320
• Last Price Increase: 2023-08-03
• Automatic offers:
• mollfpr | Reviewer | 26012873
• huzaifa-99 | Reporter | 26012875

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c94943755b5fa6d

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[akamefi202]

Proposal

Please re-state the problem that we are trying to solve in this issue.

An extra line is added to the markdown text when the user copy & paste the message which contains code snippet using selection & keyboard shortcut.

What is the root cause of that problem?

```
code
```
text

If we add above message and copy it using clipboard button and keyboard shortcut each other, different html contents are saved in clipboard.

<pre>code<br></pre>text \\ copied by clipboard button in context menu

<div><div><comment><pre><div><span>code</span><br></div></pre>text</comment></div></div> \\ copied by selection & Ctrl + C

App/src/components/Composer/index.js

Lines 298 to 301 in 34d1d95

	handlePastedHTML(html) {
	const parser = new ExpensiMark();
	this.paste(parser.htmlToMarkdown(html));
	}

If we paste it in the composer, above html texts will be parsed by handlePastedHTML function of ExpensiMark class and parsed text will be shown in the composer.

https://github.com/Expensify/expensify-common/blob/9940dd127c2d44809c98ee628a8057f08c93bfc9/lib/ExpensiMark.js#L322-L324
For parsing of code snippet, handlePastedHTML function adds head & tail line breaks.
And it removes the new line character at the end of <pre> tag if it exists, for preventing addition of new line characters.

<pre><div><span>code</span><br></div></pre>

But through rendering of HTML content, <div> tag is appended inside <pre> and also <br> tag is inside of <div> tag.
So the end new line character won't be removed and we will see an extra line in markdown text.

What changes do you think we should make in order to solve the problem?

App/src/hooks/useCopySelectionHelper.js

Lines 8 to 9 in 975146f

	function copySelectionToClipboard() {
	const selection = SelectionScraper.getCurrentSelection();

We should parse selection in advance, before saving it to clipboard & parsing it using htmlToMarkdown function.
We should remove the child <div> tag inside <pre> tag and the problem will be fixed.

function parseSelectionHtml(html) {
    return html.replace(/<pre><div>(.*?)<\/div><\/pre>/g, (match, g1) => `<pre>${g1}</pre>`);
}

We might update this parser function for further updates related to selection, or we can add it to ExpensiMark class.

What alternative solutions did you explore? (Optional)

We can add new rule to htmlToMarkdownRules of ExpensifyMark.js directly.
So we can remove the nested tag inside <pre> tag while html selection is being parsed using htmlToMarkdown function.

{
    name: 'nested',
    regex: /<(pre)(?:"[^"]*"|'[^']*'|[^'">])*><(div|code)(?:"[^"]*"|'[^']*'|[^'">])*>([\s\S]*?)<\/\2><\/pre>/gi,
    replacement: '<pre>$3</pre>'
},

[puneetlath]

@mollfpr please review when you get a chance, thanks!