[HOLD for payment 2023-08-16] [$1000] Web - The "Invalid Two Factor Authentication code" error from the 2FA page is also displayed on the contact methods page even without entering any code

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

. Go to Settings > Security > Two-factor authentication.
2. Click on "Copy" and proceed to the next step.
3. Enter an incorrect number for Two Factor Authentication.
4. Now go to the Profile > Contact methods.
5. Add a new contact method.
6. Notice that the "Invalid Two Factor Authentication code" error from the 2FA page is displayed on the contact methods page without entering any code

Expected Result:

The "Invalid Two Factor Authentication code" error should not be displayed on the contact methods page when adding a new contact method

Actual Result:

The "Invalid Two Factor Authentication code" error from the 2FA page is also displayed on the contact methods page without entering any code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-07-25-at-124605-am_d5KvKWgm.mp4

Recording.3907.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690228883804299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017b2ef3498aa199c3
• Upwork Job ID: 1686807446598131712
• Last Price Increase: 2023-08-02

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the invalid 2FA code error msg to not appear on the contact methods page when the error was previously set by the security/2FA/Verify page

What is the root cause of that problem?

Unlike the security/2FA/Verify page, we are not clearing the 2FA error when we visit the contact methods verify page.

What changes do you think we should make in order to solve the problem?

We should clear the account errors when we visit the contacts method verify page, like this

componentDidMount() {
    Session.clearAccountMessages();
}

What alternative solutions did you explore? (Optional)

N/A

[alexpensify]

I ran out of time on Thursday and was OOO yesterday. I'll try to review it over the weekend.

[alexpensify]

Not overdue - still on my testing lists

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017b2ef3498aa199c3