[Awaiting C+ payment] [$1000] App crashes on login after opening split bill details page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click on split bill
3. Enter any amount and continue
4. Select any 1 user and complete the split bill process
5. In the user report, click on split bill message to open split bill details page
6. Copy the URL, logout, paste the URL and login again, eg URL format: https://staging.new.expensify.com/r/5686244339424710/split/2464435729537161526
7. Observe that app crashes

Expected Result:

App should not crash when we open split bill details page

Actual Result:

App crashes when we logout and login with split bill details page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

crash.on.split.bill.URL.open.mp4

Recording.1336.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690262928105189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168304d5ea41d503d
• Upwork Job ID: 1684650192147705856
• Last Price Increase: 2023-07-27
• Automatic offers:
• dukenv0307 | Contributor | 25865336
• dhanashree-sawant | Reporter | 25865338

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on login after opening split bill details page

What is the root cause of that problem?

When we open split bill page by deep link, we use HOC withReportOrNotFound to display loading page if openApp API is calling

But after this API is complete, props.reportActions still is empty because it must wait openReport API is complete. That makes reportAction is empty and the app crashes when we get participantAccountIDs from reportAction

App/src/pages/iou/SplitBillDetailsPage.js

Lines 66 to 70 in 031b4a3

	const reportAction = props.reportActions[`${props.route.params.reportActionID.toString()}`];
	const participantAccountIDs = reportAction.originalMessage.participantAccountIDs;
	const participants = OptionsListUtils.getParticipantsOptions(
	_.map(participantAccountIDs, (accountID) => ({accountID, selected: true})),
	props.personalDetails,

What changes do you think we should make in order to solve the problem?

We should display loading page until both report data and report action data are loaded completely

1. Remove the HOC withReportOrNotFound, subscribe report and isLoadingReportData from Onyx

2. We should add the check to return loading page before this line

const isLoadingInitialReport = props.isLoadingReportData && _.isEmpty(props.report);
const isLoadingInitialReportActions = _.isEmpty(props.reportActions) || (props.report.isLoadingReportActions && _.isEmpty(reportAction);
const isExistReport = isLoadingInitialReport || (!_.isEmpty(props.report) && props.report.reportID);

const shouldShowLoading = (isLoadingInitialReport || isLoadingInitialReportActions) && isExistReport;
if (shouldShowLoading) {
    return <FullscreenLoadingIndicator />;
}

App/src/pages/iou/SplitBillDetailsPage.js

Line 67 in 031b4a3

const participantAccountIDs = reportAction.originalMessage.participantAccountIDs;

3. We also should bring the not found page before this line because with reportActionID is invalid or not found , App also crashes

if (_.isEmpty(reportAction) || _.isEmpty(props.report)) {
    return (
        <FullPageNotFoundView shouldShow/>
    )
}

App/src/pages/iou/SplitBillDetailsPage.js

Line 67 in 031b4a3

const participantAccountIDs = reportAction.originalMessage.participantAccountIDs;

What alternative solutions did you explore? (Optional)

NA

Result

Screencast-from-26-07-2023-01_38_16.mp4

[trjExpensify]

👋 @dukenv0307 how related is this to this issue? CC: @aldo-expensify

[dukenv0307]

@trjExpensify This issue and #21268 are different issue because the root cause is different.

[aldo-expensify]

If the root cause @dukenv0307 explained here is correct, they do appear unrelated to me.

[trjExpensify]

Cool, will move on external for now! :)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0168304d5ea41d503d

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.