[Awaiting bugzero checklist and c+ newdot payment][$2000] Empty screen shows for a brief moment in change task assignee modal

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any task report
2. Click Assignee field
3. Observe contacts list

Expected Result:

Contacts list shows immediately after skeleton

Actual Result:

Empty list shows for a brief moment before contacts list shows
Note: this doesn't happen in new task flow

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug2.mov

YFCI4302.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690261404929219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0163bd3cb559f30da0
• Upwork Job ID: 1684109952842158080
• Last Price Increase: 2023-08-11
• Automatic offers:
• tienifr | Contributor | 26196168
• situchan | Reporter | 26196170

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty screen shows for a brief moment in change task assignee modal

What is the root cause of that problem?

This problem is due to a combination of two factors:

1. A 200ms delay is added for loading the contacts list due to the search input debouncer:

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 99 to 105 in 8b23658

	useEffect(() => {
	const debouncedSearch = _.debounce(updateOptions, 200);
	debouncedSearch();
	return () => {
	debouncedSearch.cancel();
	};
	}, [updateOptions]);

2. The contacts list is only loaded after the animation transition has ended, adding a delay:

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 196 in 8b23658

shouldShowOptions={didScreenTransitionEnd}

What changes do you think we should make in order to solve the problem?

We should perform two changes:

1. updateOptions() should be called on mount.
2. Remove shouldShowOptions={didScreenTransitionEnd} so that it has its default value of true. Optionally replace with an isUpdatingOptions state that indicates completion of updateOptions().

The same problem seems to be present in TaskShareDestinationSelectorModal, SearchPage and the 2nd cause also in WorkspaceInvitePage.

Fixed result

chrome_LBiMPNYSaq.mp4

What alternative solutions did you explore? (Optional)

N/A

[kadiealexander]

Reproduced:

RPReplay_Final1690358026.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0163bd3cb559f30da0

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty screen shows for a brief moment in change task assignee modal

What is the root cause of that problem?

When the transition ends we render the options but we have to wait some times (~200ms) to get data, that why we can see the empty page for a brief moment

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 196 in 23a8a34

shouldShowOptions={didScreenTransitionEnd}

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 99 to 105 in 23a8a34

	useEffect(() => {
	const debouncedSearch = _.debounce(updateOptions, 200);
	debouncedSearch();
	return () => {
	debouncedSearch.cancel();
	};
	}, [updateOptions]);

What changes do you think we should make in order to solve the problem?

When we're getting data we should show the skeleton

In order to do that I introduce the new variable const [isLoading, setIsLoading] = React.useState(true); and update it in updateOptions function

        if(isLoading){
            setIsLoading(false)
        }

and here

shouldShowOptions={didScreenTransitionEnd && !isLoading}

Note There're other places (TaskShareDestinationSelectorModal, SearchPage, ...) face this problem so we should to apply the above logic too

Result

Screen.Recording.2023-07-26.at.15.54.27.mov