[HOLD for payment 2023-08-17] [$1000] Cannot change assignee after task created

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any task report
2. Click + on composer > Assign task
3. Click back button to close modal
4. Click Assignee field
5. Select any contact

Expected Result:

Selected contact should be assigned to the task

Actual Result:

Nothing happens but console error shows - "Cannot read property 'reportID' of undefined"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug1.mov

Recording.1332.mp4

Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690261085014579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a286825668f899a
• Upwork Job ID: 1683968213928505344
• Last Price Increase: 2023-07-25
• Automatic offers:
• situchan | Reviewer | 25863472
• dukenv0307 | Contributor | 25863473
• situchan | Reporter | 25863474

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot change assignee after task created.

What is the root cause of that problem?

If click "assign task" from composer in TaskView, Task.clearOutTaskInfoAndNavigate is called.

App/src/pages/home/report/ReportActionCompose.js

Line 461 in 74ae95c

onSelected: () => Task.clearOutTaskInfoAndNavigate(this.props.reportID),

This function clear ONYXKEYS.TASK onyx data, and navigate to new task page.

App/src/libs/actions/Task.js

Lines 562 to 566 in 74ae95c

	function clearOutTaskInfoAndNavigate(reportID) {
	clearOutTaskInfo();
	setParentReportID(reportID);
	Navigation.navigate(ROUTES.NEW_TASK_DETAILS);
	}

App/src/libs/actions/Task.js

Lines 31 to 33 in 74ae95c

	function clearOutTaskInfo() {
	Onyx.set(ONYXKEYS.TASK, null);
	}

When close the new task modal, the ONYXKEYS.TASK data doesn't revert.

And when navigate to task assignee page, because there are no props.task, so the error is occured.

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 167 in 74ae95c

if (props.route.params.reportID && props.task.report.reportID === props.route.params.reportID) {

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 223 to 225 in 74ae95c

	task: {
	key: ONYXKEYS.TASK,
	},

Therefore, user cannot select a task assignee.

What changes do you think we should make in order to solve the problem?

We can set ONYXKEYS.TASK onyx before navigating to task assignee modal in this line and this line as below.

    onPress={() => {
        Task.setTaskReport({...props.report, isExistingTaskReport: true});
        Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID));
    }}

What alternative solutions did you explore? (Optional)

None.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot change assignee after task created

What is the root cause of that problem?

We also have logic to set the task field here

App/src/components/ReportActionItem/TaskView.js

Lines 42 to 46 in 391c412

	function TaskView(props) {
	useEffect(() => {
	Task.setTaskReport({...props.report, isExistingTaskReport: true});
	}, [props.report]);

Unfortunately, setTaskReport is executed before clearOutTaskInfo, so the task field is empty

Note that this issue only happens on the assignee page (doesn't happen on the title page). This is because on the TaskTitlePage we use the report field from ONYX directly and on the TaskAssigneeSelectorModal we use task.report field from ONYX.

What changes do you think we should make in order to solve the problem?

In TaskAssigneeSelectorModal, we replace props.task.report by

lodashGet(props.reports, `report_${props.route.params.reportID}`, {})

I just tested and It works well
This is the sample PR for testing: #23530

[dukenv0307]

@robertjchen @situchan Ping you guys because we just discussed this bug here and decided to fix it separately

[situchan]

@adelekennedy I'd like to take this as C+ if possible, as this is a follow-up of issue we (@robertjchen and @dukenv0307) worked on and we have full context.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010a286825668f899a

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.