[HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open 2 accounts on 2 browsers
2. Both account open the chat
3. B send any message
4. B click another report
5. A send the message, Observed in report B not marked as unread on LHN

Expected Result:

in report B marked as unread on LHN, when B does not open the report

Actual Result:

in report B not marked as unread on LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-23.at.21.28.58.mov

Recording.1328.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690006349415999

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unread not working on the LHN.

What is the root cause of that problem?

If user B received a message from user A, the following code is executed, and then calculate new marker actions.
If the scroll position is 0, then call Report.readNewestAction in order to update report's lastReadTime.

App/src/pages/home/report/ReportActionsView.js

Lines 129 to 153 in c779139

	unsubscribeFromNewActionEvent.current = Report.subscribeToNewActionEvent(props.report.reportID, (isFromCurrentUser, newActionID) => {
	const isNewMarkerReportActionIDSet = !_.isEmpty(newMarkerReportActionID);
	// If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
	// they are now in the list.
	if (isFromCurrentUser) {
	reportScrollManager.scrollToBottom();
	// If the current user sends a new message in the chat we clear the new marker since they have "read" the report
	setNewMarkerReportActionID('');
	} else if (isReportFullyVisible) {
	// We use the scroll position to determine whether the report should be marked as read and the new line indicator reset.
	// If the user is scrolled up and no new line marker is set we will set it otherwise we will do nothing so the new marker
	// stays in it's previous position.
	if (currentScrollOffset.current === 0) {
	Report.readNewestAction(props.report.reportID);
	setNewMarkerReportActionID('');
	} else if (!isNewMarkerReportActionIDSet) {
	// The report is not in view and we received a comment from another user while the new marker is not set
	// so we will set the new marker now.
	setNewMarkerReportActionID(newActionID);
	}
	} else if (!isNewMarkerReportActionIDSet) {
	setNewMarkerReportActionID(newActionID);
	}
	});

In this issue, user B already navigates to another report, but previous report view is not unmounted, and still receive push event.
So when receive new action, Report.readNewestAction is called, and lastReadTime is updated.
Therefore, previous report does not marked as unread in LHN.

What changes do you think we should make in order to solve the problem?

We should add checking whether the report is visible (i.e. the current report) in new action event handler as below.

    unsubscribeFromNewActionEvent.current = Report.subscribeToNewActionEvent(props.report.reportID, (isFromCurrentUser, newActionID) => {
+       if (Navigation.getTopmostReportId() === props.report.reportID) {
+           return;
+       }

What alternative solutions did you explore? (Optional)

None.

[stephanieelliott]

Hey @kavimuru can you please clarify the on the repro steps? I'm not sure I understand how to test this:

1. Open 2 accounts on 2 browsers

• I open Account A on Chrome, and Account B on Safari

2. Both account open the chat

• On Account A I navigate to chat with Account B, on Account B I navigate to chat with Account A

3. B send any message

• On Account B I send a message to Account A

4. B click another report

• What does this mean -- on Account B should I be clicking into a chat with a separate user (Account X?) If no, what navigation steps should I be following?

5. A send the message, Observed in report B not marked as unread on LHN

• On Account A I send a message to Account B. Is the expectation that Account B sees this chat as unread?

[namhihi237]

Hi @stephanieelliott , All steps as you mention with step 4, I think you can click chat with Concierge. if not you can create any other report before.
Expectation: Account B sees this chat as unread on LHN => yes

[mountiny]

This was a fire and Hanno has been working on fixing it, pr is raised

[hannojg]

👋