[$1000] Web - Hitting Enter while login loading calls API again.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Login Form
2. Simulate slow network to observe the behaviour
3. Type one mail and hit enter
4. Change the mail speed & hit enter while previous login is loading.
5. Observe two API calls are going with two mail, also observe OTP form is also changes with the two different mail once OTP has been sent.

Expected Result:

We shouldn't allow API Call or changing email while loading.

Actual Result:

User is able to change the email as well as API calls are also going multiple time.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-26
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

ibc.mp4

Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689948859928519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01490293c7802bf825
• Upwork Job ID: 1683899063524028416
• Last Price Increase: 2023-08-01
• Automatic offers:
• b4s36t4 | Contributor | 25903420
• b4s36t4 | Reporter | 25903423

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hitting Enter while login loading calls API again.

What is the root cause of that problem?

RCA for this issue is here

App/src/pages/signin/LoginForm.js

Lines 185 to 203 in a97ca9b

	<TextInput
	ref={input}
	label={translate('loginForm.phoneOrEmail')}
	accessibilityLabel={translate('loginForm.phoneOrEmail')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
	value={login}
	autoCompleteType="username"
	textContentType="username"
	nativeID="username"
	name="username"
	onChangeText={onTextInput}
	onSubmitEditing={validateAndSubmitForm}
	autoCapitalize="none"
	autoCorrect={false}
	keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS}
	errorText={formErrorText}
	hasError={hasError}
	maxLength={CONST.LOGIN_CHARACTER_LIMIT}
	/>

.

For the TextInput we're never giving any disabled state so that it is listening for keyboard events which means whenever we hit Enter it calls handleKeyDown event which calls submit function.

Because of this whenever we hit enter API call is happening again.

What changes do you think we should make in order to solve the problem?

We should handle disabled state for the TextInput while login is going.

disabled={props.account.isLoading && props.account.loadingForm === CONST.FORMS.LOGIN_FORM}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01490293c7802bf825

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)