[HOLD for payment 2023-08-08] Bank account - Personal information is cleared after returning to it from 'Connect BA' page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Expensify App or go to staging.new.expensify.com
2. Open existing or create new workspace
3. Go to Connect Bank Account
4. Start 'Connect online with Plaid'
5. Select Chase Bank
6. Fill out forms on all pages including Personal Information (but don't click the confirmation button)
7. Click/tap 'Back' until you get to 'Connect BA' page
8. Go back to 'Personal Information' page by clicking/tapping 'Continue' button

Expected Result:

All fields on ' Personal Information' page have been saved

Actual Result:

All fields on ' Personal Information' page have been cleared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6137848_BA-Personal-Info-cleared-after-Back-from-connectBA.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011bb3d019d1ea96da
• Upwork Job ID: 1683458639028424704
• Last Price Increase: 2023-07-24

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The personal information is cleared when returning to it from the Connect bank account page

What is the root cause of that problem?

The personal information is stored in Onyx under key reimbursementAccountDraft, when clicking Continue on the Connect bank account page the backend resets this Onyx data, believing the bank account has changed:

What changes do you think we should make in order to solve the problem?

The backend should not reset the Onyx data as the bank account has not changed.

What alternative solutions did you explore? (Optional)

N/A

[trjExpensify]

I can reproduce this one. Adding Engineering and Internal for a second opinion on this being a backend issue.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011bb3d019d1ea96da

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

[Li357]

Is this a bug if you did not hit "Save and Continue" to save the personal details? Do we always save optimistically?