[HOLD for payment 2023-08-16] [$1000] Tooltip show email instead of display name when hover in remaining users avatar in a group

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to any account
2. Create a group chat of more than 4 people.
3. Hover on the remaining users avatar in LHN or Report header of a chat group

Expected Result:

The tooltip should display name of remaining users. Because we're showing the display name in the header already. It's inconsistency and hard for user to map emails in tooltip and display names in header

Actual Result:

The tooltip is showing emails of remaining users.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5553.mp4

Screen.Recording.2023-07-17.at.22.23.03.mov

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689607619109389

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01957373b884cf9d96
• Upwork Job ID: 1683585334338797568
• Last Price Increase: 2023-07-24
• Automatic offers:
• situchan | Reviewer | 25906124
• hoangzinh | Contributor | 25906128
• hoangzinh | Reporter | 25906134

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip show email instead of display name when hover in remaining users avatar in a group

What is the root cause of that problem?

The old tooltip text is getting from the props.icon.name

App/src/components/MultipleAvatars.js

Line 79 in 7770b86

const tooltipTexts = props.shouldShowTooltip ? _.pluck(props.icons, 'name') : [''];

And when we get the icon.name of an chat group, we're preferring the login email over the displayName

App/src/libs/ReportUtils.js

Line 754 in 7770b86

lodashGet(personalDetails, [accountID, 'login'], lodashGet(personalDetails, [accountID, 'displayName'], '')),

What changes do you think we should make in order to solve the problem?

I think we need to change the order of getting here so that we get the displayName first, then get login email as a fallback

App/src/libs/ReportUtils.js

Line 754 in 7770b86

lodashGet(personalDetails, [accountID, 'login'], lodashGet(personalDetails, [accountID, 'displayName'], '')),

[Nikhil-Vats]

@puneetlath what's the expected behaviour here?

IMO, we do see the names in the header and when we hover the names in the header, we see the mapping of names to emails. So, I think it's fine but the new tooltip looks so much better than the old one that it'd be nice if we show something like it for the remaining users (+2 icon).

[puneetlath]

Hmm, interesting. I guess showing display names instead of emails would make sense in this scenario.

[slafortune]

Yep, I think the display name would be more informative than the email at times and look cleaner.