[HOLD for payment 2023-08-21] [$1000] `errors` props are incorrectly accessed in `IOUCurrencySelection`

[marcaaron]

Coming from: #22198 (comment)

I noticed that in 3 out of 4 occurrences where shouldHideComposer is used. We are using props.errors when there is no prop errors. Here is a list -

ReportScreen - for hiding EmojiPickers

App/src/pages/home/ReportScreen.js

Line 164 in 058978e

if (ReportUtils.shouldHideComposer(this.props.report, this.props.errors)) {
MoneyRequestAmountPage - for dismissing modal
App/src/pages/iou/steps/MoneyRequestAmountPage.js

Line 213 in 058978e

if (!ReportUtils.shouldHideComposer(props.report, props.errors)) {
This one.

The only correct occurrence where errors are actually populated is in ReportFooter to hide the composer. The errors used there are -

lodashGet(report, 'errorFields.addWorkspaceRoom') || lodashGet(report, 'errorFields.createChat');

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174717ad8fbbd1e71
• Upwork Job ID: 1682495893949411328
2023-07-21
• Automatic offers:
• mollfpr | Reviewer | 25682904
• Nikhil-Vats | Contributor | 25682906

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0174717ad8fbbd1e71

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[marcaaron]

@Nikhil-Vats can you make a proposal here. First dibs are yours.