[HOLD for payment 2023-08-14] [$1000] Tasks assigned disappears from LHN when leaving the chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login and create a task
2. Assign to account B
3. Login to account B
4. Open the task
5. Switch to other chat

Expected Result:

Task is available in LHN

Actual Result:

Task gets disappeared. Tasks that are assigned to me should be pinned in LHN in #focus mode

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689746543712129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120f92e247a863177
• Upwork Job ID: 1684316072626675712
2023-07-26
• Automatic offers:
• hoangzinh | Contributor | 25855965

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The task assigned to a user disappears from the left-hand navigation (LHN) when the user navigates away from the task chat in focus mode.

What is the root cause of that problem?

The issue stems from the shouldReportBeInOptionList function which decides whether a report should show in 'focus' mode. Currently, there is no check to retain the report in the list if the user is the assignee of the task.

App/src/libs/ReportUtils.js

Lines 2125 to 2183 in 7fea760

	function shouldReportBeInOptionList(report, currentReportId, isInGSDMode, iouReports, betas, policies, allReportActions) {
	const isInDefaultMode = !isInGSDMode;
	// Exclude reports that have no data because there wouldn't be anything to show in the option item.
	// This can happen if data is currently loading from the server or a report is in various stages of being created.
	// This can also happen for anyone accessing a public room or archived room for which they don't have access to the underlying policy.
	if (
	!report ||
	!report.reportID ||
	(_.isEmpty(report.participantAccountIDs) && !isChatThread(report) && !isPublicRoom(report) && !isArchivedRoom(report) && !isMoneyRequestReport(report) && !isTaskReport(report))
	) {
	return false;
	}
	if (!canAccessReport(report, policies, betas, allReportActions)) {
	return false;
	}
	// Include the currently viewed report. If we excluded the currently viewed report, then there
	// would be no way to highlight it in the options list and it would be confusing to users because they lose
	// a sense of context.
	if (report.reportID === currentReportId) {
	return true;
	}
	// Include reports if they have a draft, are pinned, or have an outstanding IOU
	// These are always relevant to the user no matter what view mode the user prefers
	if (report.hasDraft || report.isPinned || hasOutstandingIOU(report, iouReports)) {
	return true;
	}
	// Include reports that have errors from trying to add a workspace
	// If we excluded it, then the red-brock-road pattern wouldn't work for the user to resolve the error
	if (report.errorFields && !_.isEmpty(report.errorFields.addWorkspaceRoom)) {
	return true;
	}
	// All unread chats (even archived ones) in GSD mode will be shown. This is because GSD mode is specifically for focusing the user on the most relevant chats, primarily, the unread ones
	if (isInGSDMode) {
	return isUnread(report);
	}
	// Archived reports should always be shown when in default (most recent) mode. This is because you should still be able to access and search for the chats to find them.
	if (isInDefaultMode && isArchivedRoom(report)) {
	return true;
	}
	// Exclude policy expense chats if the user isn't in the policy expense chat beta
	if (isPolicyExpenseChat(report) && !Permissions.canUsePolicyExpenseChat(betas)) {
	return false;
	}
	// Hide only chat threads that haven't been commented on (other threads are actionable)
	if (isChatThread(report) && !report.lastMessageText) {
	return false;
	}
	return true;
	}

What changes do you think we should make in order to solve the problem?

To address this issue, we could include a check within the shouldReportBeInOptionList function to determine if the user is the assignee for the task. The implementation could look like this

if (report.type === 'task') {
    if (isTaskAssignee(report)) {
        return true;
    }
}

Result:

New.Expensify.-.Google.Chrome.2023-07-21.07-17-49.mp4

[anmurali]

Rotating the assignment as I am OOO for 10 days

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.