Incosistent Offline indicator between preference page and other page.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings => Preferences
2. Toggle Offline mode
3. Observer the Offline indicator

Expected Result:

Offline indicator should have the same background color like other pages

Actual Result:

Offline indicator have the blue background color

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-18.at.09.25.09.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689647486243279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bca9ac87e0d5197b
• Upwork Job ID: 1688639292489039872
• Last Price Increase: 2023-08-07

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent Offline indicator between preference page and other page.

What is the root cause of that problem?

We're using IllustratedHeaderPageLayout to wrap Preferences page which caused the issue, because IllustratedHeaderPageLayout wrapped whole Preferences page with blue color.

App/src/components/IllustratedHeaderPageLayout.js

Line 30 in 5a07bc0

style={[StyleUtils.getBackgroundColorStyle(backgroundColor)]}

What changes do you think we should make in order to solve the problem?

Instead of setting background for whole screen, we should set blue background color for Header only by adding new props style to our HeaderWithBackButton.

        <ScreenWrapper
            shouldEnablePickerAvoiding={false}
            includeSafeAreaPaddingBottom={false}
        >
            {({safeAreaPaddingBottomStyle}) => (
                <>
                    <HeaderWithBackButton
                        // eslint-disable-next-line react/jsx-props-no-spreading
                        {...propsToPassToHeader}
                        titleColor={themeColors.iconColorfulBackground}
                        iconFill={themeColors.iconColorfulBackground}
                        style={[StyleUtils.getBackgroundColorStyle(backgroundColor)]}
                    />

What alternative solutions did you explore? (Optional)

Pass styles.appBG into our OfflineIndicator inside ScreenWrapper

[benjaminbennet]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent Offline indicator between preference page and other page.

What is the root cause of that problem?

The IllustratedHeaderPageLayout cover the screen with blue background color which cause the issue.

        <ScreenWrapper
            style={[StyleUtils.getBackgroundColorStyle(backgroundColor)]}
            shouldEnablePickerAvoiding={false}
            includeSafeAreaPaddingBottom={false}
        >

What changes do you think we should make in order to solve the problem?

We should update our OfflineIndicator with the background match with our background color:

<OfflineIndicator styles={[styles.appBg]} />

What alternative solutions did you explore? (Optional)

N/A

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incosistent Offline indicator between preference page and other page.

What is the root cause of that problem?

the background color is set to ScreenWrapper which have OfflineIndicator as child.

App/src/components/IllustratedHeaderPageLayout.js

Lines 29 to 33 in 5a07bc0

	<ScreenWrapper
	style={[StyleUtils.getBackgroundColorStyle(backgroundColor)]}
	shouldEnablePickerAvoiding={false}
	includeSafeAreaPaddingBottom={false}
	>

What changes do you think we should make in order to solve the problem?

1. remove StyleUtils.getBackgroundColorStyle(backgroundColor) from ScreenWrapper.
2. replace this fragment on line 35 with view flex1 and the same background color
   

   App/src/components/IllustratedHeaderPageLayout.js

   Lines 29 to 35 in 5a07bc0

   	<ScreenWrapper
   	style={[StyleUtils.getBackgroundColorStyle(backgroundColor)]}
   	shouldEnablePickerAvoiding={false}
   	includeSafeAreaPaddingBottom={false}
   	>
   	{({safeAreaPaddingBottomStyle}) => (
   	<>

with

<View style={[styles.flex1, StyleUtils.getBackgroundColorStyle(backgroundColor)]}>

What alternative solutions did you explore? (Optional)

[sakluger]

I do see the inconsistency:

Most pages:

Preference page:

@Expensify/design do you think this is a bug? Should we standardize on one or the other?

[shawnborton]

The offline indicator should not be blue on that page, it should match the BG color of the app. cc @roryabraham perhaps you can fix that quickly in your other animated header PR?