[HOLD for payment 2023-09-06] [$1000] SVG attachments can't be downloaded on iOS

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Attach an SVG file to a report
   1a. Example file: https://upload.wikimedia.org/wikipedia/commons/8/81/Wikimedia-logo.svg
2. Open that report in the iOS app
3. Click the link to download the SVG

Expected Result:

SVG file is downloaded

Actual Result:

Error dialog shows: "Attachment Error Attachment could not be downloaded".

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42.26
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Lizzi-Lindboe
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689624938459859

BTGH4384.1.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018370d8484a1d1e76
• Upwork Job ID: 1681897741429071872
• Last Price Increase: 2023-07-27
• Automatic offers:
• b4s36t4 | Contributor | 26075447

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

iOS <> Android issue swap.

[allroundexperts]

@kadiealexander This needs to be internal. The exact error is:

 [Error: The operation couldn’t be completed. (PHPhotosErrorDomain error 3303.)]

The error code 3303 indicates a missing resource.

The reason for it being missing is that we are not setting appropriate headers in the response when a request to download an svg image is made.

For SVG, here are the response headers:

For JPG, these are the headers:

Notice how the SVG does not contain a Content-Type header.

Looks like we need to fix this in our cloud flare workers!

[jliexpensify]

Thanks @allroundexperts - appreciate it!

[kadiealexander]

Repro:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018370d8484a1d1e76