[HOLD for payment 2023-08-24] [$1000] Profile - OfflineIndicator doesn't appear on AvatarCrop Modal.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Go to Profile => Click user photo => upload photo => choose any photo.
3. Turn off the internet connection.
4. Notice there's no OfflineIndicator at bottom.

Expected Result:

OfflineIndicator should appear at the bottom of screen.

Actual Result:

OfflineIndicator doesn't appear at the bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1689669686.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689669952378799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f624632378686b5c
• Upwork Job ID: 1681955679382212608
• Last Price Increase: 2023-08-03
• Automatic offers:
• hungvu193 | Contributor | 25948540
• hungvu193 | Reporter | 25948542

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We're not wrapping our AvatarCropModal inside ScreenWrapper which caused the issue:

App/src/components/AvatarCropModal/AvatarCropModal.js

Lines 364 to 370 in ffe659e

	{props.isSmallScreenWidth && <HeaderGap />}
	<HeaderWithBackButton
	title={props.translate('avatarCropModal.title')}
	onBackButtonPress={props.onClose}
	/>
	<Text style={[styles.mh5]}>{props.translate('avatarCropModal.description')}</Text>
	<GestureHandlerRootView

What changes do you think we should make in order to solve the problem?

Wrap the AvatarCropModal content inside ScreenWrapper:

        <Modal
            onClose={props.onClose}
            isVisible={props.isVisible}
            type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
            onModalHide={resetState}
        >
      <ScreenWrapper>
      // Modal content
      </ScreenWrapper>
       </Modal>

What alternative solutions did you explore? (Optional)

N/A

Result