[HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] [$1000] IOU Report header shows back button even on large screens.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app on staging.
2. Go to a chat, click on "+".
3. Click on request money.
4. Enter details and click on request.
5. Click on report preview to go to the new chat.
6. Notice the new IOU report chat shows back button in header.

Expected Result:

Back button should be shown only on small screens which is the case for all other report headers.

Actual Result:

Back button is shown on all screens for only IOU report headers.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-19.at.12.29.20.AM.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689706828844219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0129d2040f88d2242e
• Upwork Job ID: 1681405233161469952
• Last Price Increase: 2023-07-18

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU Report header shows back button even on large screens.

What is the root cause of that problem?

In MoneyReportHeader, we are setting shouldShowBackButton to true irrespective of screen size.

App/src/components/MoneyReportHeader.js

Lines 80 to 85 in 8c952e1

	]}
	threeDotsAnchorPosition={styles.threeDotsPopoverOffsetNoCloseButton(props.windowWidth)}
	report={props.report}
	policies={props.policies}
	personalDetails={props.personalDetails}
	shouldShowBackButton

This is not the case with other headers where we show it conditionally.

App/src/components/MoneyRequestHeader.js

Line 84 in 8c952e1

shouldShowBackButton={props.isSmallScreenWidth}

App/src/pages/home/HeaderView.js

Lines 144 to 149 in 8c952e1

	{props.isSmallScreenWidth && (
	<PressableWithoutFeedback
	onPress={props.onNavigationMenuButtonClicked}
	style={[styles.LHNToggle]}
	accessibilityHint={props.translate('accessibilityHints.navigateToChatsList')}
	accessibilityLabel={props.translate('common.back')}

What changes do you think we should make in order to solve the problem?

We need to use the same value here. In MoneyReportHeader change line 85 to -

shouldShowBackButton={props.isSmallScreenWidth}

What alternative solutions did you explore? (Optional)

NA

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

@shawnborton it looks like it's actually expected that we show a back button on both screens from the original issue

Just wanted to double check with you that this is the expected behavior. If so we can close this out.