[HOLD for payment 2023-08-10] [$1000] Web - Inconsistent behavior while choosing the option between PriorityModePage and LanguagePage.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account.
2. Open inspect, choose Network tab.
3. Go to Settings => Preferences => Language, choose the current checked language.
4. Notice that's there's no api was called.
5. Go to PriorityModePage, choose the current priority mode, notice that there's an api was called.

Expected Result:

In PriorityModePage user chose the selected value, we shouldn't call the api (like LanguagePage).

Actual Result:

In PriorityModePage user chose the selected value, the api was called every time.

Workaround:

UNknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

priority.mov

Recording.3730.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689667345964279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01174dc912248e0fd8
• Upwork Job ID: 1681381724619579392
• Last Price Increase: 2023-07-25
2023-07-18
• Automatic offers:
• hungvu193 | Reporter | 25724127
• aimane-chnaif | Reviewer | 25793802

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent behavior while choosing the option between PriorityModePage and LanguagePage.

What is the root cause of that problem?

We're updating priorityMode every time, even when user has selected the current priorityMode:

App/src/libs/actions/User.js

Lines 639 to 655 in 88b9416

	function updateChatPriorityMode(mode) {
	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_PRIORITY_MODE,
	value: mode,
	},
	];
	API.write(
	'UpdateChatPriorityMode',
	{
	value: mode,
	},
	{optimisticData},
	);
	Navigation.navigate(ROUTES.SETTINGS_PREFERENCES);
	}

What changes do you think we should make in order to solve the problem?

We should add a early return (similar to our LanguagePage logic), if user selected the current value, we should do nothing.

    const updateMode = React.useCallback((mode) => {
        if (mode.value === props.priorityMode) {
            Navigation.navigate(ROUTES.SETTINGS_PREFERENCES);
            return;
        }
        User.updateChatPriorityMode(mode.value)

    }, [props.priorityMode]);

  <SelectionListRadio
                sections={[{data: priorityModes}]}
                onSelectRow={updateMode}
                initiallyFocusedOptionKey={_.find(priorityModes, (mode) => mode.isSelected).keyForList}
            />

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01174dc912248e0fd8

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Inconsistent behavior while choosing the option between PriorityModePage and LanguagePage.

What is the root cause of that problem?

RCA for this issue is here

App/src/pages/settings/Preferences/PriorityModePage.js

Line 49 in 72bb2a2

onSelectRow={(mode) => User.updateChatPriorityMode(mode.value)}

we're not doing any check here and directly calling the API to update the preference.

What changes do you think we should make in order to solve the problem?

We should create a new function which checks that the select Mode is already selected or not.

Like below

const updatePriorityMode = (mode) => {
        if (mode.isSelected) {
            Navigation.navigate(ROUTES.SETTINGS_PREFERENCES);
            return;
        }

        User.updateChatPriorityMode(mode.value);
    };

And use this function in onSelectRow prop to not update the already selected key.

What alternative solutions did you explore? (Optional)

NA

Result

ib.webm

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Inconsistent behavior while choosing the option between PriorityModePage and LanguagePage

What is the root cause of that problem?

There is no check the passed mode is already selected or not.

App/src/libs/actions/User.js

Lines 639 to 655 in 72bb2a2

	function updateChatPriorityMode(mode) {
	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.NVP_PRIORITY_MODE,
	value: mode,
	},
	];
	API.write(
	'UpdateChatPriorityMode',
	{
	value: mode,
	},
	{optimisticData},
	);
	Navigation.navigate(ROUTES.SETTINGS_PREFERENCES);
	}

What changes do you think we should make in order to solve the problem?

To keep consistency like updating Locale, need to check the passed mode is selected previously or not.
If its already selected, skip API call to update mode and navigate previous page directly.

function updateChatPriorityMode(mode, isSelected = false) {
    if (!isSelected) {
        const optimisticData = [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: ONYXKEYS.NVP_PRIORITY_MODE,
                value: mode,
            },
        ];
        API.write(
            'UpdateChatPriorityMode',
            {
                value: mode,
            },
            {optimisticData},
        );
    }
    Navigation.navigate(ROUTES.SETTINGS_PREFERENCES);
}

and, update this line like this:

onSelectRow={(mode) => User.updateChatPriorityMode(mode.value, mode.isSelected)}

What alternative solutions did you explore? (Optional)

N/A