[HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] Clicking on 'From' link navigates to main chat rather than navigating to the previous IOU thread report

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open an existing chat
2. Click on 'Request money' link
3. Enter amount & click on 'Next' button
4. Click on 'Request' button
5. Click on IOU preview component & observe that user is navigated to IOU thread report and IOU preview component is displayed
6. Click on the IOU preview component & observe that user is navigated to a report where IOU detail is displayed
7. Click on 'From' link

Expected Result:

User should be navigated to to the IOU thread report where user was navigated on step 5

Actual Result:

User is navigated to main chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-18.17-29-49.webm

Recording.1283.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689691734672829

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on 'From' link navigates to main chat rather than navigating to the previous IOU thread report

What is the root cause of that problem?

In HeaderWithBackButton component, we are using AvatarWithDisplayName, there we are providing the report prop -

App/src/components/HeaderWithBackButton/index.js

Lines 83 to 87 in f74512d

	<AvatarWithDisplayName
	report={parentReport || report}
	policies={policies}
	personalDetails={personalDetails}
	/>

In this case if parentReport is not null, it's passed. And thus we are redirected to parentReport.

What changes do you think we should make in order to solve the problem?

We shall change it to -

report={report || parentReport}

In this case, if report is null, parentReport will be used. But for our case(in this bug) we want to be redirected to report(the page that shows IOU preview. But as parentReport being non null, it will be passed and we are redirected to the chat

Result

Correct.redirect.mp4

What alternative solutions did you explore? (Optional)