[HOLD for payment 2023-07-26] User can continue to enter magic code value while entered magic code value is being submitted

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to sign-in page (staging)
2. Enter email & click on continue
3. Enter a wrong, more than 6 digits value in the magic code input field quickly

Expected Result:

User shouldn't be able to enter magic code value while the 6-digit values are being submitted

Actual Result:

User is able to enter magic code value while the 6-digit values are submitted. The additional values the user enters are filled in the cleared magic code input field

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-18.09.27.34.mp4

Recording.1278.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689662332876779

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The magic code input can be altered while the form is being submitted.

What is the root cause of that problem?

The input is not disabled while submit is in progress.

What changes do you think we should make in order to solve the problem?

We can pass props.account.isLoading to disable the input inside MagicCodeInput if loading is true. This value is already used to disable the button:

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 312 to 319 in 960c26c

	<Button
	isDisabled={props.network.isOffline}
	success
	style={[styles.mv3]}
	text={props.translate('common.signIn')}
	isLoading={props.account.isLoading && isLoadingValidateCodeForm}
	onPress={validateAndSubmitForm}
	/>

What alternative solutions did you explore? (Optional)

N/A