[HOLD for payment 2023-12-08] [$1000] Web - App does not display working report on back from 'something is wrong page'

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report, to trigger something is wrong page, send any attachment, click on attachment and copy URL, send URL, delete the attachment and click on URL
3. Click on browser back, observe that it changes URL but it still displays something is wrong page
4. Reload and observe that app now displays proper report

Expected Result:

App should display chat report on back from 'something is wrong' page if report don't have any issue

Actual Result:

App still displays 'something is wrong' page on browser back click even though app changes URL to a working report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

something.is.wrong.back.button.wrong.working.mp4

Recording.3714.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689531247187909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f4efb0d0e28187e6
• Upwork Job ID: 1682055964789444608
• Last Price Increase: 2023-11-20
• Automatic offers:
• 0xmiroslav | Reviewer | 27774673
• WikusKriek | Contributor | 27774676
• dhanashree-sawant | Reporter | 27774677

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DanutGavrus]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not display working report on back from 'something is wrong page'

What is the root cause of that problem?

1. We throw an error if we don't find the attachment:
   

   App/src/components/AttachmentCarousel/index.js

   Lines 192 to 195 in ab3d0e8

   	const page = _.findIndex(attachments, (a) => a.source === this.props.source);
   	if (page === -1) {
   	throw new Error('Attachment not found');
   	}

2. We never clear that error, so pressing on the back button, still shows the Error page.

What changes do you think we should make in order to solve the problem?

To fix 1st problem:

Instead of throwing an error, we could show the FullPageNotFoundView, and optionally, we could add a `Log` and a new text in our languages to show a custom error.

if (page === -1) {
    Log.warn('Attachment not found'); // Optional
    return {
        attachmentNotFound: true,
    }
}

<FullPageNotFoundView
  shouldShow={this.state.attachmentNotFound}
  subtitleKey='notFound.attachmentYouLookingForCannotBeFound' // Optional
  >
  <View

Add to en.js file(Optional, we'll also need the Spanish translation):

notFound: {
  attachmentYouLookingForCannotBeFound: 'The attachment you are looking for cannot be found.',

To fix 2nd problem:

Inside BaseErrorBoundary component, add the componentDidMount method which is not yet present. In it, we'll add a listener which clears the existing error when user presses on the back button(if it exists):

componentDidMount() {
    window.onpopstate = () => {
        if (this.state.hasError) {
            this.clearError();
        }
    }
}

Adding the listener in the componentDidMount method will not flash the page when user presses on the back button.

[michaelhaxhiu]

This is a very edge case bug, but it is indeed "inconsistent" from the behavior we'd expect in the app. I think we should try to fix it (and hopefully it's not a big undertaking to do so).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f4efb0d0e28187e6

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.