[HOLD for payment 2023-08-28] [$1000] splitting bill with phone account shows @expensify.sms

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. login with an sms account
2. split bill with a few members
3. Check the who paid field's subtitle text

Expected Result: @expensify.sms should not be shown

Actual Result:

@expensify.sms should is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-07-14.14-53-13-346.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688810314872429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128597348b75205c2
• Upwork Job ID: 1682899214742786048
• Last Price Increase: 2023-08-05
• Automatic offers:
• chiragxarora | Contributor | 26071204
• chiragxarora | Reporter | 26071208
• situchan | Contributor | 26071280

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

PROPOSAL

Please re-state the problem that we are trying to solve in this issue.

splitting bill with phone account shows @expensify.sms

What is the root cause of that problem?

Root cause of the issue is that in split bill flow, when we are fetching the payee's personal details by the method getIOUConfirmationOptionsFromPayeePersonalDetail, we have not formatted the text and alternate text which we end up showing in <MoneyRequestConfirmationList/> > <OptionsSelector/>

App/src/libs/OptionsListUtils.js

Lines 878 to 894 in 60f4817

	function getIOUConfirmationOptionsFromPayeePersonalDetail(personalDetail, amountText) {
	return {
	text: personalDetail.displayName ? personalDetail.displayName : personalDetail.login,
	alternateText: personalDetail.login || personalDetail.displayName,
	icons: [
	{
	source: UserUtils.getAvatar(personalDetail.avatar, personalDetail.accountID),
	name: personalDetail.login,
	type: CONST.ICON_TYPE_AVATAR,
	id: personalDetail.accountID,
	},
	],
	descriptiveText: amountText,
	login: personalDetail.login,
	accountID: personalDetail.accountID,
	};
	}

What changes do you think we should make in order to solve the problem?

We need to format the alternate text and display name fields using formatPhoneNumber() method in LocalePhoneNumber util

What alternative solutions did you explore? (Optional)

We can find other inconsistencies (if any) and fix them all at once

[MitchExpensify]

Commented in Slack

[melvin-bot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Confirmed @expensify.sms is not expected to be shown anywhere in app

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128597348b75205c2