[HOLD for payment 2023-08-24] [HOLD for payment 2023-08-21] [$1000] Split bill - 'No results found' appears after selecting the user in split bill member search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Click + icon > Split bill > Enter amount > Next.
3. Type an email address.
4. Select the member in search result

Expected Result:

There is no error message after selecting the member in the search result

Actual Result:

No results found' appears after selecting the member in the search result

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.3.41.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6127080_20230713_235416.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Interanl Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0199d5a89c5f1a937a
• Upwork Job ID: 1681294844527841280
• Last Price Increase: 2023-08-01
• Automatic offers:
• fedirjh | Reviewer | 25952719

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No results found appears after selecting the user in split bill number search

What is the root cause of that problem?

The root cause of the issue is that when selecting a participant which does not exist and needs to be invited, after getting selected, we're emptying our userToInvite array. This is incorrect since the user still needs to be invited. Since the invited user array is empty, when getting the header message here, we get a no result found error to show up.

What changes do you think we should make in order to solve the problem?

Similar to how this is being done in the new chat page, we can change this to:

const chatOptions = OptionsListUtils.getNewChatOptions(reports, personalDetails, betas, searchTerm, [], CONST.EXPENSIFY_EMAILS);

Then, we'll need to change this to:

const chatOptions = OptionsListUtils.getNewChatOptions(reports, personalDetails, betas, searchTerm, [], CONST.EXPENSIFY_EMAILS);

We'll finally also need to replace this with:

  const filterText = _.reduce(participants, (str, {login}) => `${str} ${login}`, '');
  const hasUnselectedUserToInvite = newChatOptions.userToInvite && !filterText.includes(newChatOptions.userToInvite.login);

  if (hasUnselectedUserToInvite) {

What alternative solutions did you explore? (Optional)

We need to replace this with:

        newChatOptions.personalDetails.length + 
        newChatOptions.recentReports.length + 
        _.filter(participants, ({login}) => login.includes(searchTerm)).length !== 0,

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0199d5a89c5f1a937a

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[mallenexpensify]

The root cause of the issue is that when selecting a participant which does not exist and needs to be invited,

@allroundexperts , this happens with existing accounts too, was able to reproduce