[HOLD for payment 2024-08-07] [$1000] Extra space around text in header of reply in thread if main message has 3 backtick code block

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send message with 3 backtick code block in it eg: hi hello test
4. Hover and click on reply in thread
5. Observe the header text, it will have extra spaces around text which was 3 backtick code block

Expected Result:

Format of text should not affect reply in thread header text formatting

Actual Result:

3 backtick code blocks in text adds extra space around the text in reply in thread header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-13.23-21-57.mp4

Recording.3603.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689183843669479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010cf4dbd8dbc4da67
• Upwork Job ID: 1684257620704722944
• Last Price Increase: 2023-08-09
• Automatic offers:
• tienifr | Contributor | 26112867
• dhanashree-sawant | Reporter | 26112869

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra space around text in header of reply in thread if main message has 3 backtick code block.

What is the root cause of that problem?

The root cause of this issue is that we format header of report thread by replacing line break of message[0].text with a space, see

App/src/libs/ReportUtils.js

Line 1125 in 754b6ed

const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');

So, there's will be an extra space added for message[0].text, like hi \nhello.

What changes do you think we should make in order to solve the problem?

To fix this issue, we can convert html lodashGet(parentReportAction, ['message', 0, 'html'], '') to markdown text and then get the first line of the markdown text.

To achieve it, we can change this line

App/src/libs/ReportUtils.js

Line 1252 in ac74ab9

const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');

to

const parser = new ExpensiMark();
const parentReportActionMessage = parser.htmlToMarkdown(lodashGet(parentReportAction, ['message', 0, 'html'], '')).trim().replace(CONST.REGEX.AFTER_FIRST_LINE_BREAK, '');

What alternative solutions did you explore? (Optional)

If we don't want to show the Markdown in the title, then we can just get the first line of

lodashGet(parentReportAction, ['message', 0, 'text'], '')

by changing this line

App/src/libs/ReportUtils.js

Line 1252 in ac74ab9

const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');

to

const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').trim().replace(CONST.REGEX.AFTER_FIRST_LINE_BREAK, '');

[flaviadefaria]

I'm discussing it in Slack here to confirm what would be the expected result.

[melvin-bot]

@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@flaviadefaria Still overdue 6 days?! Let's take care of this!

[flaviadefaria]

After discussing in Slack we agreed that the intended outcome should be:

• Only the first line of the message should display on the thread title
• Markdown, if in a thread title, should display as markdown