[HOLD for payment 2023-08-03] [$1000] mWeb - Horizontal message settings being displayed on mobile

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Open a chat
2. Click with 2 fingers on 2 different message twice

Expected Result:

The comment action menu should only open on one long press on one comment

Actual Result:

The comment action menu opens when tapping quickly on separate comments

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen.mov

Screen_Recording_20230712_130622_Chrome.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @mejed-alkoutaini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689119360544589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2c7a6952e9ef076
• Upwork Job ID: 1679930169256824832
• Last Price Increase: 2023-07-14

[esh-g]

Proposal

Please re-state the issue

Mini report action context menu is visible on small screen devices.

What is the root cause of that problem?

The menu is supposed to be visible when there is a hover action and mainly this is possible with a mouse, but sometimes, hover can be triggered on a click as well.

What changes do you think we should make in order to solve this problem?

In this file:

App/src/pages/home/report/ReportActionItem.js

Lines 466 to 473 in 29ae942

	<MiniReportActionContextMenu
	reportID={props.report.reportID}
	reportAction={props.action}
	isArchivedRoom={ReportUtils.isArchivedRoom(props.report)}
	displayAsGroup={props.displayAsGroup}
	isVisible={hovered && !props.draftMessage && !hasErrors}
	draftMessage={props.draftMessage}
	isChronosReport={ReportUtils.chatIncludesChronos(props.report)}

We should add !this.props.isSmallWidthScreen condition to isVisible prop with a logical AND.

What other alternative approaches did you explore?

N/A

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

It might be difficult to reproduce... So be sure to check the slack convo

[MitchExpensify]

This requires a physical android which I do not have, looking for another Bug Zero volunteer to take this on 👁️

[MitchExpensify]

Asked here for help https://expensify.slack.com/archives/C01SKUP7QR0/p1689200759769169

[MitchExpensify]

Clarified expected and actual here https://expensify.slack.com/archives/C049HHMV9SM/p1689201312520879?thread_ts=1689119360.544589&cid=C049HHMV9SM

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A mini context menu shows on mobile web

What is the root cause of that problem?

The mini context menu will show if the message is being hovered. The hover state is handled by the Hoverable component that depends on onMouseEnter event. In mobile web, onMouseEnter will be triggered when we simply click the component/element, but we already prevent that by disabling the hover when a touch starts.

App/src/components/Hoverable/index.js

Lines 21 to 32 in 451096b

	// we like to Block the hover on touch devices but we keep it for Hybrid devices so
	// following logic blocks hover on touch devices.
	this.disableHover = () => {
	this.hoverDisabled = true;
	};
	this.enableHover = () => {
	this.hoverDisabled = false;
	};
	document.addEventListener('touchstart', this.disableHover);
	// Remember Touchend fires before `mouse` events so we have to use alternative.
	document.addEventListener('touchmove', this.enableHover);

But then we re-enable it when setIsHovered is passed with a false value. This happens when onMouseLeave is triggered. To trigger the event, just click/press on the other message.

This works, but not reliable.

To easily reproduce it, keep clicking/pressing on multiple messages to mess up the hoverDisabled value.

Screen.Recording.2023-07-13.at.18.15.32.mov

What changes do you think we should make in order to solve the problem?

If the device doesn't support hover event, we should early return the children.

if (!DeviceCapabilities.hasHoverSupport()) return child;

then remove the hoverDisabled variable.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2c7a6952e9ef076