[HOLD for payment 2023-07-26] [$1000] Attachments not shown for sender, stuck at 'Uploading attachment...'

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Open any chat (group or 1:1)
• Add an image attachment
• Uploading attachment... should show temporarily

Expected Result:

• After upload, other users should see the attachment
• After upload, the uploader should image attachment should show

Actual Result:

• After upload, other users can see the attachment ✅
• After upload, the uploader cannot see the image attachment ('Uploading attachment...' is still shown) ❌

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• [?] iOS / native
• [?] iOS / Safari
• [?] MacOS / Chrome / Safari
• [?] MacOS / Desktop

Version Number: 1.3.39-5 and 1.3.38-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Me
Slack conversation: N/A

Uploader (jules) sees:

Other user sees:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019a63d2e48d9abd42
• Upwork Job ID: 1679142267668922368
• Last Price Increase: 2023-07-12

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

Hi @JmillsExpensify, do you recall anything unusual about the profile image file you used? I have only ever seen this issue on messages from you 😅

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachments not shown for sender, stuck at 'Uploading attachment...'

What is the root cause of that problem?

Seems we are passing wrong value(undefined) here for prevVisibleMessageText Localize.translateLocal in the latest PR which seems breaking the flow for attachment.

App/src/libs/actions/Report.js

Lines 248 to 250 in 29ae942

	let prevVisibleMessageText;
	if (lastVisibleMessage.lastMessageTranslationKey) {
	prevVisibleMessageText = Localize.translateLocal(prevVisibleMessageText);

1a7bbcf#diff-8afe5b71ee0436c21364148c86dadd640f2bff3e3d916addbb1f1f6f7e5b6a43R248-R250

What changes do you think we should make in order to solve the problem?

We need to correct the value we are passing. cc: @roryabraham
prevVisibleMessageText = Localize.translateLocal(lastVisibleMessage.lastMessageTranslationKey);

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019a63d2e48d9abd42