Skip to content

[HOLD for payment June 29] Update compose box to send photos and text in one message #2258

@kadiealexander

Description

@kadiealexander

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

  1. When uploading image attachments in Expensify.cash, the existing attachment preview modal should appear. Instead of saying "Upload", it should now say "Send".

This should work the same for all three modes of interaction:
- Manually picking an image using the AttachmentPicker,
- Drag-and-dropping a photo into the ReportActionCompose,
- Pasting a photo into the ReportActionCompose from the platform's native clipboard.

  1. After hitting "Send", any draft text in the composition box should be sent, followed by the attached image below the text.

@mallenexpensify @shawnborton if you have nothing else to add here then feel free to apply the External label so we can get this on Upwork.

Actual Result:

  • Image uploads and text in compose box persists.

Action Performed:

Web/Desktop

  • Type text in compose box
  • Drag/drop image to compose box to upload
  • Click 'Upload`

Mobile web/app

  • Type text in compose box
  • Tap attachment/paperclip icon
  • Tap Photo Library or Choose from Gallery
  • Select photo and tap Choose or Upload to upload

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/156214
Platform - version: All

Notes/Photos/Videos:
Big ol' thread in Slack - link
iOS/Messenger is what we're wanting to mimic
IMG_5636

IMG_5637

Slack does a good job of handling this but they put they post the text above the image.
image

Metadata

Metadata

Labels

ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions