[HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] Login - Crash when navigating to the concierge chat via deeplink after login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log out of NewDot
2. Go to https://staging.new.expensify.com/concierge
3. Verify that you are taken to the login screen
4. Log in to NewDot with any account

Expected Result:

You're navigated to the concierge chat after login

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6121132_Recording__5388.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cdf0596ececb29a0
• Upwork Job ID: 1683603845958860801
• Last Price Increase: 2023-07-24

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when navigating to Conceirge page via deeplink after login

What is the root cause of that problem?

In the navigateToConveirgeChat in Report.js, this is the condition

if (!Navigation.getReportIDFromRoute()) {
            Navigation.navigate(ROUTES.REPORT);
        }

This Navigation has no function called getReportIDFromRoute, so app crashes

What changes do you think we should make in order to solve the problem?

We change that check to

if (!Navigation.getTopmostReportID()) {
            Navigation.navigate(ROUTES.REPORT);
        }

[francoisl]

@c3024 are you available to submit a PR for this please?

[francoisl]

Since this is a deploy blocker, I'm going to submit a PR now.