[HOLD for payment 2023-07-26] dev: There is no consistency between the input field to enter task title and edit task title

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Click + in composer => assign task
3. Input title, Observe that it is not possible to enter multiple lines here
4. Next => Confirm
5. Click on task title
6. Edit title, Observe that multiple lines can be entered here

Expected Result:

There must be consistency between the creation and editing of the input task title box

Actual Result:

no consistency between the input field to enter task title and edit task title

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev only
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-08.at.18.06.22.mov

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688814642406699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0118c6f4fd728fc15b
• Upwork Job ID: 1678580224333312000
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There must be consistency between the creation and editing of the input task title box

What is the root cause of that problem?

Here we have the difference between input title at create task and edit title:
Create:

App/src/pages/tasks/NewTaskDetailsPage.js

Lines 93 to 100 in 60f4817

	<TextInput
	ref={(el) => (inputRef.current = el)}
	inputID="taskTitle"
	label={props.translate('task.title')}
	value={taskTitle}
	onValueChange={(value) => setTaskTitle(value)}
	/>
	</View>

Edit:

App/src/pages/tasks/TaskTitlePage.js

Lines 77 to 86 in 60f4817

	<TextInput
	inputID="title"
	name="title"
	autoGrowHeight
	textAlignVertical="top"
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	label={props.translate('task.title')}
	defaultValue={(props.report && props.report.reportName) || ''}
	ref={(el) => (inputRef.current = el)}
	/>

Easy to see the difference here is the screen TaskTitlePage we allow autoGrowHeight.

What changes do you think we should make in order to solve the problem?

We should remove autoGrow Height from autoGrowHeight

                    <TextInput
                        inputID="title"
                        name="title"
                        textAlignVertical="top"
                        label={props.translate('task.title')}
                        defaultValue={(props.report && props.report.reportName) || ''}
                        ref={(el) => (inputRef.current = el)}
                    />

What alternative solutions did you explore? (Optional)

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

title filed is multiline filed while editing title

What is the root cause of that problem?

Tilte filed is multiline filed

What changes do you think we should make in order to solve the problem?

remove the autoGrowHeight prop from TaskTitlePage.js also remove unnecessary prop textAlignVertical="top”

App/src/pages/tasks/TaskTitlePage.js

Lines 77 to 86 in 60f4817

	<TextInput
	inputID="title"
	name="title"
	autoGrowHeight
	textAlignVertical="top"
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	label={props.translate('task.title')}
	defaultValue={(props.report && props.report.reportName) || ''}
	ref={(el) => (inputRef.current = el)}
	/>

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

the edited input is autoGrowHeight and there is no submitOnEnter.

What is the root cause of that problem?

the edited input has prop autoGrowHeight and no prop submitOnEnter while is the only input on the screen.

What changes do you think we should make in order to solve the problem?

remove two prop autoGrowHeight and textAlignVertical and add new prop submitOnEnter here.

App/src/pages/tasks/TaskTitlePage.js

Line 77 in 60f4817

<TextInput

What alternative solutions did you explore? (Optional)

[chiragxarora]

regression of a recent PR #20841

@jasperhuangg

[jasperhuangg]

Happy to investigate/fix this. Thanks for the ping

[jasperhuangg]

Tackling this internally