[HOLD for payment 2023-08-01] [$1000] User was not shown on Invite members page after immediately inviting

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to workspace invite member page -> Invite
2. Type a new user whom you have not interacted yet
3. Invite them
4. Observe invite member page

Expected Result:

The invited user should immediately show up in the invite member page

Actual Result:

The invited user shows up after sometime

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-08.at.12.15.02.AM.mov

Recording.1213.mp4

Expensify/Expensify Issue URL:
Issue reported by: @abdulrahuman5196
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688755739075519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0101aca3aeff5e6e57
• Upwork Job ID: 1678399914954649600
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inviting users you have not interacted with to a workspace do not immediately show.

What is the root cause of that problem?

When inviting members, the ONYXKEYS.PERSONAL_DETAILS_LIST data is not optimistically set for users where no prior interaction has taken place.

App/src/libs/actions/Policy.js

Lines 362 to 371 in 60f4817

	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: membersListKey,
	// Convert to object with each key containing {pendingAction: ‘add’}
	value: _.object(accountIDs, Array(accountIDs.length).fill({pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD})),
	},
	...membersChats.onyxOptimisticData,
	];

This leads to the members not being rendered and an error being logged.

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 371 to 375 in 60f4817

	const details = props.personalDetails[accountID];
	if (!details) {
	Log.hmmm(`[WorkspaceMembersPage] no personal details found for policy member with accountID: ${accountID}`);
	return;
	}

What changes do you think we should make in order to solve the problem?

In Policy.addMembersToWorkspace(), the optimistically set data must include ONYXKEYS.PERSONAL_DETAILS_LIST information for users for whom it does not exist.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0101aca3aeff5e6e57

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[maddylewis]

C+ assigned to review existing proposal