[HOLD for payment 2023-07-26] [$1000] Web - Clear error message is not shown in close account page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > security > close account
2. Put your default contact method inside the second input field but add a dot "." at the end of the email
3. Click Close account

Expected Result:

A clear error message should be shown that would help the user correct any mistakes put inside the input box

Actual Result:

A generic error message is shown and user might not be able to clearly understand what is going wrong

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3450.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688627237644589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0147a52638811e5555
• Upwork Job ID: 1678509423767924736
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Please type your default method ... has email@email.com. which can be confusing if someone exactly copies and pastes it.

What is the root cause of that problem?

We added this . here to make it like a sentence

<Text style={[styles.mt5]}>
                        {props.translate('closeAccountPage.enterDefaultContactToConfirm')} <Text style={[styles.textStrong]}>{userEmailOrPhone}</Text>.
                    </Text>

What changes do you think we should make in order to solve the problem?

Remove the dot at the end
and change it to this

<Text style={[styles.mt5]}>
                        {props.translate('closeAccountPage.enterDefaultContactToConfirm')} <Text style={[styles.textStrong]}>{userEmailOrPhone}</Text>
                    </Text>

[jeet-dhandha]

Not a bug as firestore also ask user to enter collection name when deleting the collection. If we enter wrong collection name, it just shows below message.

[Nathan-Mulugeta]

Firebase's error message is clear enough. ND's error is not clear enough to alarm user to edit the input, it just says input email. It doesn't even add the word "correctly", I think it should at least add that IMO

[kbecciv]

@maddylewis Can we fix the dot in the end of contact method as well? or I need a separate bug for it?

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688647630285239

[c3024]

The dot at the end should be fixed here in my opinion.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0147a52638811e5555