[$2000] Split bill - Split bill is displayed twice if swipe back from split bill chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Tap on "+" FAB
3. Tap "Split bill"
4. Enter amount
5. Tap "Next"
6. Select users
7. Tap "Next"
8. Tap "Split"
9. Swipe to the right
10. Swipe to the right again

Expected Result:

User lands in LHN either at step 9 or 10

Actual Result:

"Split bill enter mount" page is displayed twice when user swipes to the right at steps 9 and 10 from split bill chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6117693_IMG_8395.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019fd945448c329b5e
• Upwork Job ID: 1679918056642871296
• Last Price Increase: 2023-09-05

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[manjesh-yadav]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill is displayed twice if swipe back from split bill chat

What is the root cause of that problem?

We should not Enforces navigation to fallback route when a money request has already been created and we have a new moneyRequestId it forces to reload the same route again when we go back

What changes do you think we should make in order to solve the problem?

We should navigate back if IOU report is already created

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 65 in 2607bde

navigateBack(true);

Changes

useEffect(() => {
        // ID in Onyx could change by initiating a new request in a separate browser tab or completing a request
        if (prevMoneyRequestId.current !== props.iou.id) {
            // The ID is cleared on completing a request. In that case, we will do nothing
            if (props.iou.id) {
                navigateBack(true);
            }
            return;
        }

        // Reset the money request Onyx if the ID in Onyx does not match the ID from params
        const moneyRequestId = `${iouType.current}${reportID.current}`;
        const shouldReset = props.iou.id !== moneyRequestId;
        if (shouldReset) {
            IOU.resetMoneyRequestInfo(moneyRequestId);
        }

        if (props.iou.amount === 0 || shouldReset) {
-            navigateBack(true);
+          navigateBack();
        }

        return () => {
            prevMoneyRequestId.current = props.iou.id;
        };
    }, [props.iou.amount, props.iou.id]);

Result

Online

RPReplay_Final1688641548.MP4

offline

RPReplay_Final1688641597.MP4

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

@flaviadefaria Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@flaviadefaria 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019fd945448c329b5e

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.