[HOLD for payment 2023-08-02] [$1000] Web - Assignee and share somewhere deep link closes RHN on selection even though it intiates changes

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click plus and click on 'Assign task'
3. Enter any title and click on next
4. Click on assignee and copy the URL
5. Close the RHN, paste URL in any report and send
6. Click on the URL from report and click on any user in assignee list, observe that it closes RHN
7. Again click on URL and click on back, observe that assignee selected in step 6 was saved

Expected Result:

App should not close the RHN menu on selection of assignee or selection of user in share somewhere

Actual Result:

App closes the RHN menu on selection of assignee or selection of user in share somewhere when assignee and share somewhere pages are opened using deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3424.mp4

deep.link.share.and.assignee.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688486902490709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d444ffece6132556
• Upwork Job ID: 1676994558637928448
• Last Price Increase: 2023-07-13

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

assignee and share somewhere deep link closes RHN on selection even though it intiates changes

What is the root cause of that problem?

We go back after selecting assignee or shareSomeWhere and the URL doesn't contain reportID

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 162 in 15e547e

return Navigation.goBack();

App/src/pages/tasks/TaskShareDestinationSelectorModal.js

Line 121 in 15e547e

Navigation.goBack();

What changes do you think we should make in order to solve the problem?

We should go back to the new task page same as when we click on the back button

return Navigation.goBack(ROUTES.NEW_TASK)} 

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 181 in 15e547e

onBackButtonPress={() => Navigation.goBack(ROUTES.NEW_TASK)}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d444ffece6132556

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[Israr-ul-haq]

Hi I saw the job on upwork I think I can help you with this if you want me to contribute in this issue