[HOLD for payment 2023-07-14] Web- A Green 'Yes, Continues' button is shown when closing an account.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings
2. Click on Security and then choose Close Account
3. Write your default contact method and click on Close Account.
4. Notice that "Closing your account cannot be undone" message pops up with a Green 'Yes, Continues' button.

Expected Result:

A Red 'Yes, Continues' button is shown

Actual Result:

A Green 'Yes, Continues' button is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test45_Closinggreenbutton-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688188374632229

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[parasharrajat]

This was missed accidentally during the refactoring of the concerned component. Refactor PR was on hold for a long time and this change was done during that period. It got overlooked during the merge conflict resolution.

I have created a PR to solve it.

[parasharrajat]

@dylanexpensify you either assign an engineer here or wait for the PR to be merged. No C+ will be required here because I was C+ on original PR.

This was the original PR #19328 which caused this issue. To speed up the things, I am creating the PR being C+ on it.

[dylanexpensify]

Ah nice, thanks for the context @parasharrajat! How long do you think it will take for the PR to be merged? This will help inform if I assign an engineer here!

[parasharrajat]

As soon as an engineer is assigned to merge it. PR is #22251

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green "Yes,Continue" button instead of red button when closing an account

What is the root cause of that problem?

App/src/pages/settings/Security/CloseAccountPage.js

Lines 111 to 120 in 4f9f428

	<ConfirmModal
	title={props.translate('closeAccountPage.closeAccountWarning')}
	onConfirm={onConfirm}
	onCancel={hideConfirmModal}
	isVisible={isConfirmModalVisible}
	prompt={props.translate('closeAccountPage.closeAccountPermanentlyDeleteData')}
	confirmText={props.translate('common.yesContinue')}
	cancelText={props.translate('common.cancel')}
	shouldShowCancelButton
	/>

There is no danger props here. This is the root cause
This was from #19328

What changes do you think we should make in order to solve the problem?

Add danger props to the ConfirmModal component

This works as expected.

What alternative solutions did you explore? (Optional)

[dylanexpensify]

this is intentional!

[parasharrajat]

Is the green button intentional? Did you confirm this @dylanexpensify?