[HOLD for payment 2023-08-08] [$1000] DEV: Consle error on type email in close account page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Security > Close account
2. Type email in default contact method

Expected Result:

Should not show any console error

Actual Result:

Shows console error( Warning: A component is changing an uncontrolled input to be controlled.)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.36-2
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-04.at.11.29.06.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688450371798469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0145e1a7bcc7178873
• Upwork Job ID: 1676305250007711744
• Last Price Increase: 2023-07-04

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bhargavagonugunta]

i did not found any bug regarding this issue

[melvin-bot]

📣 @bhargavagonugunta! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bhargavagonugunta]

Contributor details: bhargava naga raviteja
Your Expensify account email: bhargavagonugunta123@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5bdebd526b4f100

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When type email in close account page, console warnings

What is the root cause of that problem?

We didn't provide input controls with initial value. This warning happens when initial value is undefined.

This is the root cause

What changes do you think we should make in order to solve the problem?

We can provide the form with draftValues props that has initial values for inputs

        draftValues={{reasonForLeaving: 'sss', phoneOrEmail: ''}}

This works as expected.

What alternative solutions did you explore? (Optional)

[bhargavagonugunta]

please Re-state the problem there is no bug hear verify below

[dummy-1111]

The issue is the console warning in main branch, not on staging or production

[bhargavagonugunta]

Screen.Recording.2023-07-04.at.6.19.00.PM.mov

[parasharrajat]

cc: @hannojg This is related to the BaseTextInput refactor PR.

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Consle error on typing email in close account page -

A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen.

What is the root cause of that problem?

In this PR the BaseTextInput component was refactored to use the value prop directly rather than controlling its own internal state. Read the PR description to know more.

Now, we pass props.value to the RNTextInput component -

App/src/components/TextInput/BaseTextInput.js

Line 340 in 3e0d7dd

value={props.value}

props.value is undefined initially and changes to a string when user types hence we see the warning.

What changes do you think we should make in order to solve the problem?

We need to change line 340 to -

value={props.value || ''}

What alternative solutions did you explore? (Optional)

Alternatively, we can use inputValue defined in the beginning -

App/src/components/TextInput/BaseTextInput.js

Lines 24 to 25 in 3e0d7dd

	function BaseTextInput(props) {
	const inputValue = props.value || props.defaultValue || '';

We can pass inputValue to value prop of RNTextInput -

value={inputValue}

Optionally, since inputValue also takes care of defaultValue we can remove the defaultValue prop passed separately -

App/src/components/TextInput/BaseTextInput.js

Line 343 in 3e0d7dd

defaultValue={props.defaultValue}