[HOLD for payment 2023-08-08] [$1000] Web - Assign Task - Delay in transitioning from a hand cursor to a "not allowed" sign.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Clicked on the plus sign.
2. Clicked on "Assign Task".
3. Entered the title and clicked on "Next".
4. Filled in the "Assignee" and "Share somewhere" fields.
5. Clicked on "Confirm Task".
6. Upon clicking the "Mark as Done" button, the completed task is indicated by a green tick.
7. Observed a delay in the transition from a hand cursor to a "not allowed" sign.

Expected Result:

The transition from a hand cursor to a "not allowed" sign should occur without any delay.

Actual Result:

There is a delay in the transition from a hand cursor to a "not allowed" sign.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

Bug.4.mp4

Recording.5281.mp4

Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688195714793539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01620c737f6783071d
• Upwork Job ID: 1678893891094454272
• Last Price Increase: 2023-07-18

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hnkuanx]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When task is marked as completed, there is a delay before the cursor on the "To" row (including Completed status) get changed to disabled cursor

What is the root cause of that problem?

In PressableWithFeedback, the implementation will set setIsExecuting(true) when button is pressed, and then setIsExecuting(false) when interaction completed, the idea is to prevent registering quick repeated pressing, but when the onPress function executes really quickly, it caused a flashing of cursor from default to disabled, then back to default cursor

Therefore, there was a fix #18862 to introduce a delay of 1000ms after isDisabled:true before the cursor actually get changed to disabled style, to eliminate the flashing.
That is the cause of 1 second delay in cursor change after marking a task as completed, as reported in this ticket.

What changes do you think we should make in order to solve the problem?

There is nothing wrong with the implementation, however the fixed delay of 1000ms is too long, we should set it to shorter time e.g. 100ms which would also prevent the cursor flashing, and does not add much of the delay of change in term of UX.

https://github.com/Expensify/App/blob/main/src/components/Pressable/GenericPressable/BaseGenericPressable.js#L121

What alternative solutions did you explore? (Optional)

[melvin-bot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@michaelhaxhiu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01620c737f6783071d

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.